RESOLVED FIXED 97804
[CSS Exclusions] ExclusionShape class should provide a lineOverlapsShapeBounds() method 
https://bugs.webkit.org/show_bug.cgi?id=97804
Summary [CSS Exclusions] ExclusionShape class should provide a lineOverlapsShapeBound...
Hans Muller
Reported 2012-09-27 11:22:00 PDT
It would be more efficient if the ExclusionShape class provided a lineOverlapsShapeBounds() method, than the current approach where ExclusionShapeInsideInfo computes the result by getting the shape's bounding box: inline bool ExclusionShapeInsideInfo::lineOverlapsShapeBounds() const { ASSERT(m_shape); FloatRect shapeBounds = m_shape->shapeLogicalBoundingBox(); return m_lineTop <= shapeBounds.maxY() && m_lineBottom >= shapeBounds.y(); } By calling an ExclusionShape() method directly we could avoid allocating a FloatRect and doing the extra internal to logical conversions.
Attachments
Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2013-04-11 13:19:26 PDT
It has been fixed earlier. Current function: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/ExclusionShapeInfo.h?rev=147384#L99 bool lineOverlapsShapeBounds() const { return logicalLineTop() < shapeLogicalBottom() && logicalLineBottom() >= shapeLogicalTop(); }
Note You need to log in before you can comment on or make changes to this bug.