WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
87129
Remove getPropertyShorthand from the web exposed API.
https://bugs.webkit.org/show_bug.cgi?id=87129
Summary
Remove getPropertyShorthand from the web exposed API.
Alexis Menard (darktears)
Reported
2012-05-22 06:47:49 PDT
Remove getPropertyShorthand from the web exposed API.
Attachments
Patch
(21.63 KB, patch)
2012-05-22 07:26 PDT
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Patch
(22.47 KB, patch)
2012-05-22 08:13 PDT
,
Alexis Menard (darktears)
timothy
: review-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1
2012-05-22 07:26:57 PDT
Created
attachment 143297
[details]
Patch
Build Bot
Comment 2
2012-05-22 08:06:24 PDT
Comment on
attachment 143297
[details]
Patch
Attachment 143297
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/12764011
Alexis Menard (darktears)
Comment 3
2012-05-22 08:13:37 PDT
Created
attachment 143303
[details]
Patch
WebKit Review Bot
Comment 4
2012-05-22 08:15:42 PDT
Please wait for approval from
timothy@apple.com
(or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Timothy Hatcher
Comment 5
2012-05-22 12:46:05 PDT
Comment on
attachment 143303
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=143303&action=review
> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:-981 > -- (NSString *)getPropertyShorthand:(NSString *)propertyName AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER;
This is public API. It should stay, removing it is binary incompatible. If we wish to remove it we should mark it as deprecated for one release.
Alexis Menard (darktears)
Comment 6
2012-05-28 05:05:51 PDT
I saw you guys branched for Safari, is there a way to mark it deprecated there and remove it here in trunk? I don't how work the releases inside Apple but that's a random thought.
Timothy Hatcher
Comment 7
2012-05-28 11:18:30 PDT
It should be deprecated in trunk.
Sam Sneddon [:gsnedders]
Comment 8
2020-10-12 11:04:48 PDT
Assuming Alexis is no longer working on this after eight years, so unassigning. I believe this exists for the sake of Web Inspector, so Brian probably cares.
Ahmad Saleem
Comment 9
2022-08-12 12:07:32 PDT
This still exist:
https://github.com/WebKit/WebKit/blob/b336a53b180ca88e40fef99e7f0a0779bd3d5986/Source/WebCore/css/CSSStyleDeclaration.idl#L42
Is it removed from all browsers? (Just for my learning). Thanks!
Radar WebKit Bug Importer
Comment 10
2022-11-13 21:30:52 PST
<
rdar://problem/102303976
>
Darin Adler
Comment 11
2022-11-13 22:38:07 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6456
EWS
Comment 12
2022-11-14 00:18:47 PST
Committed
256636@main
(80c7a3df3ee1): <
https://commits.webkit.org/256636@main
> Reviewed commits have been landed. Closing PR #6456 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug