RESOLVED FIXED 33082
Do not include Frame.h under WebCore/html/canvas 
https://bugs.webkit.org/show_bug.cgi?id=33082
Summary Do not include Frame.h under WebCore/html/canvas
Laszlo Gombos
Reported 2009-12-31 08:36:42 PST
I change in JavaScriptCore/runtime/Structure.h prompted a rebuild of WebCore/html/canvas/CanvasRenderingContext2D.cpp. I found this a bit strange and after looking into it, it turned out that this dependency can be easily broken by not including Frame.h in WebCore/html/canvas/CanvasRenderingContext2D.cpp (which is the only file under WebCore/html/canvas which includes Frame.h). Here is the ChangeSet that removed the Frame dependency but failed to remove the Frame.h include - http://trac.webkit.org/changeset/21749/trunk/WebCore/html/CanvasRenderingContext2D.cpp.
Attachments
proposed patch (1.04 KB, patch)
2009-12-31 08:39 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-12-31 08:39:08 PST
Created attachment 45711 [details] proposed patch
WebKit Review Bot
Comment 2 2009-12-31 08:42:33 PST
style-queue ran check-webkit-style on attachment 45711 [details] without any errors.
Kenneth Rohde Christiansen
Comment 3 2009-12-31 09:25:47 PST
Comment on attachment 45711 [details] proposed patch LGTM
Laszlo Gombos
Comment 4 2009-12-31 09:56:15 PST
Comment on attachment 45711 [details] proposed patch Thanks for the review !
WebKit Commit Bot
Comment 5 2009-12-31 10:07:13 PST
Comment on attachment 45711 [details] proposed patch Clearing flags on attachment: 45711 Committed r52682: <http://trac.webkit.org/changeset/52682>
WebKit Commit Bot
Comment 6 2009-12-31 10:07:18 PST
All reviewed patches have been landed. Closing bug.
Laszlo Gombos
Comment 7 2009-12-31 10:14:58 PST
just a note - unrelated bot failure on "SnowLeopard Intel Leaks" bot; as the the bot seemed to run out of disk space. Failed to open temp file in /var/folders/Qe/QejWyO1eEHebyJWD9dE3TU+++TM/-Tmp-//, error: No space left on device Command /Developer/usr/bin/g++-4.2 failed with exit code 1 Command /Developer/usr/bin/g++-4.2 failed with exit code 1 ** BUILD FAILED ** The following build commands failed: WebKit: Ld /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/WebKit.framework/Versions/A/WebKit normal x86_64 (1 failure)
Simon Hausmann
Comment 8 2010-01-05 00:55:33 PST
Cherry-picked into qtwebkit-4.6 as 75ab03a8db2cc638957ba2c3c7accfb7723eebb1
Note You need to log in before you can comment on or make changes to this bug.