RESOLVED FIXED 278742
[ews-build] Highlight flaky API test failures when tests fails in first run but passes in rerun 
https://bugs.webkit.org/show_bug.cgi?id=278742
Summary [ews-build] Highlight flaky API test failures when tests fails in first run b...
Ryan Haddad
Reported 2024-08-27 13:53:37 PDT
If an API test fails in EWS during the run-api-tests step but passes on the re-run-api-tests step, the build summary text is "Passed API tests" (see https://ews-build.webkit.org/#/builders/13/builds/59018). However, when a test fails in the `re-run-api-tests` step but passes in the `run-api-tests-without-change` the build has the status text says "Found flaky tests:..." (see https://ews-build.webkit.org/#/builders/13/builds/58962). We should unify the behavior between these two cases.
Attachments
Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2024-08-27 13:55:14 PDT
I think I'm in favor of both cases showing "Found flaky tests", since that makes it clearer why a build like https://ews-build.webkit.org/#/builders/13/builds/59018 has a longer duration than one like https://ews-build.webkit.org/#/builders/13/builds/59037 when viewing a builder page.
Radar WebKit Bug Importer
Comment 2 2024-08-27 13:55:33 PDT
<rdar://problem/134807630>
Aakash Jain
Comment 3 2024-08-28 13:01:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32847
EWS
Comment 4 2024-08-28 13:42:14 PDT
Committed 282861@main (f9b9656704d7): <https://commits.webkit.org/282861@main> Reviewed commits have been landed. Closing PR #32847 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.