RESOLVED FIXED234049
Move FontFamilySpecificationCoreText's fontMap to FontCache 
https://bugs.webkit.org/show_bug.cgi?id=234049
Summary Move FontFamilySpecificationCoreText's fontMap to FontCache
Cameron McCormack (:heycam)
Reported 2021-12-08 18:14:46 PST
Move FontFamilySpecificationCoreText's fontMap to FontCache
Attachments
Patch (24.58 KB, patch)
2021-12-08 18:16 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
DetailsFormatted DiffDiff
Patch (23.77 KB, patch)
2022-07-20 21:16 PDT, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-12-08 18:16:26 PST
Created attachment 446469 [details] Patch
Myles C. Maxfield
Comment 2 2021-12-10 15:11:19 PST
Comment on attachment 446469 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446469&action=review > Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm:51 > + // FIXME: Should clear this on all workers. I think some members on the team prefer for FIXMEs to have Bugzilla links > Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:-39 > -struct FontFamilySpecificationKey { It's kind of sad that this has to live in a different file, far from its use. This cache isn't really reusable, and FontFamilySpecificationCoreText.cpp is already fairly focused and cohesive with this in it. Can you think of a way to keep this code closer to its use?
Cameron McCormack (:heycam)
Comment 3 2021-12-10 15:26:33 PST
The obvious thing would be to make the HashMap be heap allocated and then there'd be no need for the hash traits to be in a header. What do you think of the balance of having the HashMap be in a heap allocation versus keeping it all in the same file?
Myles C. Maxfield
Comment 4 2021-12-10 16:00:44 PST
🤔
Myles C. Maxfield
Comment 5 2021-12-10 16:01:17 PST
This doesn't seem worth a heap allocation, I think
Radar WebKit Bug Importer
Comment 6 2021-12-15 18:15:17 PST
<rdar://problem/86552797>
Matt Woodrow
Comment 7 2022-07-20 21:16:20 PDT
Created attachment 461073 [details] Patch
EWS
Comment 8 2022-07-21 14:32:23 PDT
Committed 252710@main (498e08540016): <https://commits.webkit.org/252710@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461073 [details].
Note You need to log in before you can comment on or make changes to this bug.