RESOLVED FIXED 178098
Web Inspector: Network Tab - Show initially loaded resources even if network info not logged 
https://bugs.webkit.org/show_bug.cgi?id=178098
Summary Web Inspector: Network Tab - Show initially loaded resources even if network ...
Joseph Pecoraro
Reported 2017-10-09 15:43:54 PDT
Network Tab - Show initially loaded resources even if network info not logged When just opening Web Inspector it is often weird that the Network table is empty when the page has some resources. Lets try including all of the page resources in the Table even though they don't have networking data.
Attachments
[IMAGE] Table - Inspector Was Open + Reload (139.67 KB, image/png)
2017-10-09 15:59 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] Table - Inspector Just Opened (113.63 KB, image/png)
2017-10-09 16:00 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (6.94 KB, patch)
2017-10-09 16:00 PDT, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-10-09 15:44:02 PDT
<rdar://problem/34073529>
Joseph Pecoraro
Comment 2 2017-10-09 15:59:58 PDT
Created attachment 323234 [details] [IMAGE] Table - Inspector Was Open + Reload
Joseph Pecoraro
Comment 3 2017-10-09 16:00:21 PDT
Created attachment 323235 [details] [IMAGE] Table - Inspector Just Opened
Joseph Pecoraro
Comment 4 2017-10-09 16:00:59 PDT
Created attachment 323236 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 5 2017-10-09 17:38:41 PDT
Comment on attachment 323236 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=323236&action=review r=me. Would like to see another patch tho, specifically for the ChangeLog fixes. > Source/WebInspectorUI/ChangeLog:12 > + So treat hasResposne Oops. :P > Source/WebInspectorUI/ChangeLog:23 > + While this path is not taken pre-table, change this so that if it is > + that the resouce is not lost and is instead a pending insertion. "so that if it is that" is a bit awkward :/ > Source/WebInspectorUI/UserInterface/Models/Resource.js:656 > + return !isNaN(this._statusCode) || this._finished; Will this cause problems with WI.ResourceHeadersContentView (or WI.ResourceTimelineDataGridNode)? > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:105 > + WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFrameDidChange, this._mainFrameDidChange, this); Can we move this to an `initialLayout()`? The other event listeners too?
Joseph Pecoraro
Comment 6 2017-10-09 18:08:21 PDT
Comment on attachment 323236 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=323236&action=review >> Source/WebInspectorUI/UserInterface/Models/Resource.js:656 >> + return !isNaN(this._statusCode) || this._finished; > > Will this cause problems with WI.ResourceHeadersContentView (or WI.ResourceTimelineDataGridNode)? They have been updated. >> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:105 >> + WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFrameDidChange, this._mainFrameDidChange, this); > > Can we move this to an `initialLayout()`? The other event listeners too? That would be too late.
Joseph Pecoraro
Comment 7 2017-10-11 01:00:15 PDT
<https://trac.webkit.org/changeset/223170/webkit>
Note You need to log in before you can comment on or make changes to this bug.