Bug 94926

Summary: Remove parent pointer from StyleSheetContents and StyleRuleImport
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED LATER    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, cmarcelo, dglazkov, kling, macpherson, menard, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95070    
Bug Blocks: 77745    
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-06
none
with less (?) bugs none

Antti Koivisto
Reported 2012-08-24 05:41:52 PDT
To able to cache and share imported stylesheets they must not have parent pointers.
Attachments
patch (30.01 KB, patch)
2012-08-24 06:00 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (672.88 KB, application/zip)
2012-08-24 06:38 PDT, WebKit Review Bot 		no flags
Details
with less (?) bugs (30.47 KB, patch)
2012-08-26 12:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-08-24 06:00:47 PDT
Created attachment 160407 [details] patch
WebKit Review Bot
Comment 2 2012-08-24 06:38:45 PDT
Comment on attachment 160407 [details] patch Attachment 160407 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13597129 New failing tests: fast/dom/HTMLLinkElement/link-onerror.html fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
WebKit Review Bot
Comment 3 2012-08-24 06:38:48 PDT
Created attachment 160412 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Antti Koivisto
Comment 4 2012-08-26 12:23:27 PDT
Created attachment 160612 [details] with less (?) bugs
Andreas Kling
Comment 5 2012-08-26 14:17:34 PDT
Comment on attachment 160612 [details] with less (?) bugs View in context: https://bugs.webkit.org/attachment.cgi?id=160612&action=review r=me > Source/WebCore/css/StyleRuleImport.h:-59 > - // NOTE: We put the CachedStyleSheetClient in a member instead of inheriting from it > - // to avoid adding a vptr to StyleRuleImport. > - class ImportedStyleSheetClient : public CachedStyleSheetClient { Glad to see this hack disappear! > Source/WebCore/css/StyleSheetContents.cpp:340 > + m_didLoadErrorOccur = true; Sidenote: m_didLoadErrorOccur is a pretty awkward variable name.
Antti Koivisto
Comment 6 2012-08-26 14:52:59 PDT
(In reply to comment #5) > Sidenote: m_didLoadErrorOccur is a pretty awkward variable name. Yeah, I was trying to resist unrelated refactorings.
Antti Koivisto
Comment 7 2012-08-26 16:48:58 PDT
http://trac.webkit.org/changeset/126717
Csaba Osztrogonác
Comment 8 2012-08-27 05:56:12 PDT
(In reply to comment #7) > http://trac.webkit.org/changeset/126717 It caused a regression, could you check it, please? Here is the new bug report - https://bugs.webkit.org/show_bug.cgi?id=95070
Csaba Osztrogonác
Comment 9 2012-09-05 23:11:13 PDT
Please don't ignore the regression you caused - https://bugs.webkit.org/show_bug.cgi?id=95070
Alexey Proskuryakov
Comment 10 2012-09-14 12:05:20 PDT
Rolled out in <http://trac.webkit.org/changeset/128637>, because this caused flakiness.
Ahmad Saleem
Comment 11 2022-09-12 09:24:08 PDT
Is this need anymore or we can mark this as "RESOLVED LATER"? Thanks!
Note You need to log in before you can comment on or make changes to this bug.