Bug 94585

Summary:

range-hit-test-with-padding.html fails unless subpixel layout is on

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, tkent, tmpsantos, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

94595

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from gce-cr-linux-03	none
Patch	none

Keishi Hattori

Reported 2012-08-21 04:09:45 PDT

Slider thumb width is an odd number and we divide that by two, so we get different results depending on whether subpixel layout is turned on or not.

Attachments
Patch (3.61 KB, patch) 2012-08-21 05:36 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (1.93 KB, patch) 2012-08-21 06:01 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-03 (505.20 KB, application/zip) 2012-08-21 10:34 PDT, WebKit Review Bot	no flags	Details
Patch (2.59 KB, patch) 2012-08-21 17:55 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2012-08-21 05:36:44 PDT

Created attachment 159666 [details] Patch

Kent Tamura

Comment 2 2012-08-21 05:48:26 PDT

Comment on attachment 159666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9 > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;"> > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;"> I recommend adding some step value.

Kent Tamura

Comment 3 2012-08-21 05:53:38 PDT

(In reply to comment #2) > (From update of attachment 159666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review > > > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9 > > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;"> > > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;"> > > I recommend adding some step value. I mean increasing the step value. e.g. step=20

Keishi Hattori

Comment 4 2012-08-21 06:01:29 PDT

Created attachment 159672 [details] Patch

Keishi Hattori

Comment 5 2012-08-21 06:04:05 PDT

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 159666 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=159666&action=review > > > > > LayoutTests/fast/forms/range/range-hit-test-with-padding.html:9 > > > -<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 20px;"> > > > +<input id="input" type=range min=0 max=1000 step=1 value="0" style="width: 100px; padding: 0 40px;"> > > > > I recommend adding some step value. > > I mean increasing the step value. e.g. step=20 That is much better! Adjusted the max to 25 so this will work as long as the thumb width is less than 50px.

Thiago Marcos P. Santos

Comment 6 2012-08-21 06:20:47 PDT

This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working. Try changing to something like "padding: 0 400px;" and test on chromium.

Thiago Marcos P. Santos

Comment 7 2012-08-21 06:21:59 PDT

(In reply to comment #6) > This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working. > > Try changing to something like "padding: 0 400px;" and test on chromium. Sorry for bumping. By test here I'm talking about see how it looks like on the browser.

Thiago Marcos P. Santos

Comment 8 2012-08-21 06:29:15 PDT

(In reply to comment #7) > (In reply to comment #6) > > This wont work. The problem here is the left padding is being ignored. That's the reason why removing the padding offset from clickSlider() on EFL was working. > > > > Try changing to something like "padding: 0 400px;" and test on chromium. > > Sorry for bumping. By test here I'm talking about see how it looks like on the browser. Argh, EFL padding is broken. Sorry for the noise.

WebKit Review Bot

Comment 9 2012-08-21 10:34:52 PDT

Comment on attachment 159672 [details] Patch Attachment 159672 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13551362 New failing tests: fast/forms/range/range-hit-test-with-padding.html

WebKit Review Bot

Comment 10 2012-08-21 10:34:55 PDT

Created attachment 159719 [details] Archive of layout-test-results from gce-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Keishi Hattori

Comment 11 2012-08-21 17:55:13 PDT

Created attachment 159825 [details] Patch

WebKit Review Bot

Comment 12 2012-08-21 19:17:10 PDT

Comment on attachment 159825 [details] Patch Clearing flags on attachment: 159825 Committed r126252: <http://trac.webkit.org/changeset/126252>

WebKit Review Bot

Comment 13 2012-08-21 19:17:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.