Bug 93346

Summary: REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, dpranke, ojan, ossy, tmpsantos, webkit.review.bot
Priority: P1 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 93026    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-08-07 01:55:56 PDT
Fix is coming soon.
Attachments
Patch (4.12 KB, patch)
2012-08-07 02:04 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-08-07 02:04:24 PDT
Created attachment 156896 [details] Patch
Csaba Osztrogonác
Comment 2 2012-08-07 02:07:16 PDT
That's why we need "Unexpected" instead of "unexpected" in the result: Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg ----------------------------------------------------------- ... def _parseNewRunWebKitTestsOutput(self, logText): incorrectLayoutLines = [] expressions = [ ('flakes', re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)')), ('new passes', re.compile(r'Expected to .+, but passed:\s+\((\d+)\)')), ('missing results', re.compile(r'no expected results found\s*:\s+\((\d+)\)')), ('failures', re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)')), ] testFailures = {} ...
Simon Hausmann
Comment 3 2012-08-07 02:10:29 PDT
Comment on attachment 156896 [details] Patch rs=me
Simon Hausmann
Comment 4 2012-08-07 02:10:49 PDT
Comment on attachment 156896 [details] Patch rs=me
Csaba Osztrogonác
Comment 5 2012-08-07 02:15:38 PDT
Committed r124870: <http://trac.webkit.org/changeset/124870>
Note You need to log in before you can comment on or make changes to this bug.