Bug 92983

Summary: [CSS Regions] Implement the getRegions() API and add the Region interface methods on Element
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dglazkov, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93240, 93256    
Bug Blocks: 92089    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Patch none

Andrei Bucur
Reported 2012-08-02 06:33:23 PDT
The Region supplemental interface implementation is postponed until another type of container is available. For now, move the Region members on Element and implement them there.
Attachments
Patch (41.03 KB, patch)
2012-08-02 09:03 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (40.97 KB, patch)
2012-08-02 09:31 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (41.08 KB, patch)
2012-08-02 09:53 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (546.04 KB, application/zip)
2012-08-02 11:08 PDT, WebKit Review Bot 		no flags
Details
Patch (40.58 KB, patch)
2012-08-03 05:15 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2012-08-02 09:03:47 PDT
Created attachment 156102 [details] Patch
Andrei Bucur
Comment 2 2012-08-02 09:31:56 PDT
Created attachment 156108 [details] Patch
Andrei Bucur
Comment 3 2012-08-02 09:53:22 PDT
Created attachment 156112 [details] Patch
WebKit Review Bot
Comment 4 2012-08-02 11:08:26 PDT
Comment on attachment 156112 [details] Patch Attachment 156112 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13404885 New failing tests: svg/custom/detached-outermost-svg-crash.html fast/dom/domListEnumeration.html fast/dom/plugin-attributes-enumeration.html
WebKit Review Bot
Comment 5 2012-08-02 11:08:30 PDT
Created attachment 156126 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Andrei Bucur
Comment 6 2012-08-03 05:15:30 PDT
Created attachment 156333 [details] Patch
Adam Barth
Comment 7 2012-08-03 10:36:43 PDT
Comment on attachment 156333 [details] Patch LGTM. If possible, I'd prefer if someone else gave the official r+ because there's a bunch of regions details in here that I don't fully understand.
Andrei Bucur
Comment 8 2012-08-06 05:48:36 PDT
I've broken the patch in two parts: b93240 -> Add the getRegions() API call b93256 -> Rename regionOverflow to regionOverset
Note You need to log in before you can comment on or make changes to this bug.