Bug 92479

Summary: Add runtime flag to enable/disable JS memory information
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: WebKit QtAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 90858, 92498    
Attachments:
Description Flags
proposed patch
hausmann: review-, hausmann: commit-queue-
proposed patch none

Zoltan Horvath
Reported 2012-07-27 02:51:22 PDT
We need console.memory JS object to be accessible for performance tests memory consumption measurements.
Attachments
proposed patch (1.32 KB, patch)
2012-07-27 02:53 PDT, Zoltan Horvath 		hausmann: review-
hausmann: commit-queue-
DetailsFormatted DiffDiff
proposed patch (3.04 KB, patch)
2012-07-27 05:48 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-07-27 02:53:34 PDT
Created attachment 154889 [details] proposed patch
Simon Hausmann
Comment 2 2012-07-27 02:58:39 PDT
Comment on attachment 154889 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > Source/WebKit/qt/Api/qwebsettings.cpp:274 > + settings->setMemoryInfoEnabled(true); What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness?
Zoltan Horvath
Comment 3 2012-07-27 03:05:57 PDT
(In reply to comment #2) > (From update of attachment 154889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > > > Source/WebKit/qt/Api/qwebsettings.cpp:274 > > + settings->setMemoryInfoEnabled(true); > > What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness? It will enable WebCore/page/MemoryInfo.h. We should expose it only for DRT/WTR, where is the better place to set this enabled?
Simon Hausmann
Comment 4 2012-07-27 03:13:25 PDT
(In reply to comment #2) > (From update of attachment 154889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154889&action=review > > > Source/WebKit/qt/Api/qwebsettings.cpp:274 > > + settings->setMemoryInfoEnabled(true); > > What's the implication of enabling this? Should this be only done when running inside DRT or the performance test harness? Perhaps InternalSettings.idl?
Simon Hausmann
Comment 5 2012-07-27 05:07:41 PDT
Comment on attachment 154889 [details] proposed patch Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :)
Zoltan Horvath
Comment 6 2012-07-27 05:09:19 PDT
(In reply to comment #5) > (From update of attachment 154889 [details]) > Taking this out of the review queue. I'm not sure we want this to be exposed in regular production use, so this patch is going to need an iteration :) Sure, thanks! I will upload the patch soon. :)
Zoltan Horvath
Comment 7 2012-07-27 05:48:08 PDT
Created attachment 154914 [details] proposed patch
WebKit Review Bot
Comment 8 2012-07-27 10:19:31 PDT
Comment on attachment 154914 [details] proposed patch Clearing flags on attachment: 154914 Committed r123881: <http://trac.webkit.org/changeset/123881>
WebKit Review Bot
Comment 9 2012-07-27 10:19:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.