Bug 91651

Summary: [Chromium] Support external autofill popups
Product: WebKit Reporter: Peter Beverloo <peter>
Component: WebKit APIAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, jrg, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91648    
Attachments:
Description Flags
work in progress
none
Patch
none
Patch for landing none

Peter Beverloo
Reported 2012-07-18 12:34:18 PDT
This is used by Chromium for Android. The downstream patch' SHA is e8870ae.
Attachments
work in progress (2.10 KB, patch)
2012-07-19 13:43 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2012-07-19 14:38 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.22 KB, patch)
2012-07-19 15:07 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-19 12:52:12 PDT
To save other folks the research, I think what's left here is WebView::selectAutofillSuggestionAtIndex
Adam Barth
Comment 2 2012-07-19 13:43:55 PDT
Created attachment 153338 [details] work in progress
Adam Barth
Comment 3 2012-07-19 14:38:55 PDT
Created attachment 153347 [details] Patch
WebKit Review Bot
Comment 4 2012-07-19 14:45:13 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Darin Fisher (:fishd, Google)
Comment 5 2012-07-19 14:50:56 PDT
Comment on attachment 153347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153347&action=review > Source/WebKit/chromium/ChangeLog:8 > + This looks like the last piece of needed to support external autofill nit: "last piece [--of--] needed to support external" > Source/WebKit/chromium/ChangeLog:9 > + popups. This funtion just lets the embedder select an index (presumably nit: funtion -> function
Adam Barth
Comment 6 2012-07-19 15:07:56 PDT
Created attachment 153359 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-07-19 16:27:49 PDT
Comment on attachment 153359 [details] Patch for landing Clearing flags on attachment: 153359 Committed r123160: <http://trac.webkit.org/changeset/123160>
WebKit Review Bot
Comment 8 2012-07-19 16:27:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.