Bug 90693

Summary: [Gtk] Remove SVG_FEATURES and HTML_FEATURES from Source/WebCore/GNUmakefile.am
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebCore Misc.Assignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87127    
Attachments:
Description Flags
Patch pnormand: review+

Zan Dobersek
Reported 2012-07-06 10:02:31 PDT
SVG_FEATURES and HTML_FEATURES variables are not required, they can be removed, using the FEATURE_DEFINES variable instead.
Attachments
Patch (7.28 KB, patch)
2012-07-06 10:06 PDT, Zan Dobersek 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-07-06 10:06:21 PDT
Created attachment 151097 [details] Patch
Philippe Normand
Comment 2 2012-07-06 10:28:05 PDT
Comment on attachment 151097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151097&action=review > Source/WebCore/GNUmakefile.am:543 > - $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --tags $(WebCore)/svg/svgtags.in --attrs $(WebCore)/svg/svgattrs.in --factory --wrapperFactory --outputDir "$(GENSOURCES_WEBCORE)" > -endif # SVG_FLAGS > + $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --tags $(WebCore)/svg/svgtags.in --attrs $(WebCore)/svg/svgattrs.in --extraDefines "$(FEATURE_DEFINES)" --factory --wrapperFactory --outputDir "$(GENSOURCES_WEBCORE)" Isn't this change inducing a "leak" of all (including non-svg) defines in the generated file? A wild guess though, I haven't looked at this perl script.
Zan Dobersek
Comment 3 2012-07-06 11:21:02 PDT
(In reply to comment #2) > (From update of attachment 151097 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151097&action=review > > Isn't this change inducing a "leak" of all (including non-svg) defines in the generated file? A wild guess though, I haven't looked at this perl script. It technically does, the feature defines are then used when the tags and attributes files are run through the preprocessor[1][2]. Don't think there's any negative effects to it, though. [1] http://trac.webkit.org/browser/trunk/Source/WebCore/dom/make_names.pl#L269 [2] http://trac.webkit.org/browser/trunk/Source/WebCore/dom/make_names.pl#L281
Zan Dobersek
Comment 4 2012-08-13 04:42:48 PDT
Committed r125408: <http://trac.webkit.org/changeset/125408>
Note You need to log in before you can comment on or make changes to this bug.