Bug 89067

Summary:

Add color property to input type=range

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, macpherson, menard, simon.fraser, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

87844

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ec2-cr-linux-03	none
Patch	none

Keishi Hattori

Reported 2012-06-13 23:56:47 PDT

This is in preparation for supporting tick marks for datalist for input type=range.

Attachments
Patch (31.66 KB, patch) 2012-06-14 00:01 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (31.80 KB, patch) 2012-06-14 00:16 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (28.74 KB, patch) 2012-06-14 05:03 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (574.93 KB, application/zip) 2012-06-14 13:56 PDT, WebKit Review Bot	no flags	Details
Patch (35.45 KB, patch) 2012-06-14 22:52 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2012-06-14 00:01:38 PDT

Created attachment 147500 [details] Patch

Keishi Hattori

Comment 2 2012-06-14 00:16:49 PDT

Created attachment 147503 [details] Patch

Kent Tamura

Comment 3 2012-06-14 00:25:09 PDT

Comment on attachment 147500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147500&action=review > LayoutTests/ChangeLog:28 > + * platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: I don't think this change is necessary. > LayoutTests/fast/forms/range/slider-zoomed-expected.txt:2 > -PASS: slider value set to 72 > +FAIL: expected slider value 72, got 71 I don't think this change is valid. > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > +layer at (0,0) size 800x600 > + RenderView at (0,0) size 800x600 Why do we need to update the whole file? > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > +layer at (0,0) size 800x600 ditto.

Kent Tamura

Comment 4 2012-06-14 03:42:18 PDT

(In reply to comment #3) > > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > > +layer at (0,0) size 800x600 > > + RenderView at (0,0) size 800x600 > > Why do we need to update the whole file? > > > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > > +layer at (0,0) size 800x600 > > ditto. Oh, I understand. The colors are different in platforms. So we can't share some test results.

Keishi Hattori

Comment 5 2012-06-14 05:03:23 PDT

Created attachment 147556 [details] Patch

Keishi Hattori

Comment 6 2012-06-14 05:04:01 PDT

(In reply to comment #3) > (From update of attachment 147500 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147500&action=review > > > LayoutTests/ChangeLog:28 > > + * platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: > > I don't think this change is necessary. Removed. > > LayoutTests/fast/forms/range/slider-zoomed-expected.txt:2 > > -PASS: slider value set to 72 > > +FAIL: expected slider value 72, got 71 > > I don't think this change is valid. Removed. > > LayoutTests/platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt:2 > > +layer at (0,0) size 800x600 > > + RenderView at (0,0) size 800x600 > > Why do we need to update the whole file? > > > LayoutTests/platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt:1 > > +layer at (0,0) size 800x600 > > ditto. > > Oh, I understand. The colors are different in platforms. So we can't share some test results. Yes.

Kent Tamura

Comment 7 2012-06-14 05:06:24 PDT

Comment on attachment 147556 [details] Patch ok. Please watch the buildbots and take care of test failures when you land the patch.

WebKit Review Bot

Comment 8 2012-06-14 13:55:56 PDT

Comment on attachment 147556 [details] Patch Attachment 147556 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12956445 New failing tests: fast/repaint/slider-thumb-float.html fast/dom/HTMLInputElement/input-slider-update.html fast/dom/HTMLInputElement/input-slider-update-styled.html fast/repaint/slider-thumb-drag-release.html

WebKit Review Bot

Comment 9 2012-06-14 13:56:01 PDT

Created attachment 147646 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Keishi Hattori

Comment 10 2012-06-14 22:52:32 PDT

Created attachment 147738 [details] Patch

WebKit Review Bot

Comment 11 2012-06-14 23:53:09 PDT

Comment on attachment 147738 [details] Patch Clearing flags on attachment: 147738 Committed r120411: <http://trac.webkit.org/changeset/120411>

WebKit Review Bot

Comment 12 2012-06-14 23:53:15 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 13 2012-06-15 11:07:49 PDT

This broke several tests on Mac, e.g. http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r120468%20(115)/fast/forms/box-shadow-override-pretty-diff.html

Keishi Hattori

Comment 14 2012-06-18 03:30:23 PDT

(In reply to comment #13) > This broke several tests on Mac, e.g. > http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r120468%20(115)/fast/forms/box-shadow-override-pretty-diff.html I'm terribly sorry. Thank you for rebaselining.

Note You need to log in before you can comment on or make changes to this bug.