Bug 88778

Summary: [CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mihnea, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87640    
Attachments:
Description Flags
Patch
none
Patch none

Andrei Bucur
Reported 2012-06-11 06:39:14 PDT
The CSS Regions spec requests that the regionLayoutUpdate event be dispatched on the NamedFlow object, not on the attached regions. http://www.w3.org/TR/css3-regions/#region-flow-layout-events
Attachments
Patch (61.35 KB, patch)
2012-07-17 04:53 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch (61.62 KB, patch)
2012-08-01 08:06 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2012-07-17 04:53:41 PDT
Created attachment 152736 [details] Patch
Adam Barth
Comment 2 2012-07-24 17:27:09 PDT
Comment on attachment 152736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152736&action=review I didn't review the tests that carefully because I presume these are reworks of the tests you're removing. > Source/WebCore/ChangeLog:17 > + No new tests (OOPS!). This line will prevent the patch from landing. Can you update this to list the test that you've added? > Source/WebCore/dom/WebKitNamedFlow.h:65 > + virtual const AtomicString& interfaceName() const; > + virtual ScriptExecutionContext* scriptExecutionContext() const; We've been adding the OVERRIDE keyword to overrides of these functions.
Andrei Bucur
Comment 3 2012-08-01 08:06:16 PDT
Created attachment 155812 [details] Patch
WebKit Review Bot
Comment 4 2012-08-01 11:42:45 PDT
Comment on attachment 155812 [details] Patch Clearing flags on attachment: 155812 Committed r124350: <http://trac.webkit.org/changeset/124350>
WebKit Review Bot
Comment 5 2012-08-01 11:42:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.