Bug 88707

Summary: Web Inspector: Implement snippets evaluation.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, haraken, japhet, jochen, joepeck, keishi, loislo, pfeldman, pmuellr, rik, syoichi, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 90385    
Bug Blocks: 75094    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-06-09 05:34:29 PDT
Patch to follow.
Attachments
Patch (28.15 KB, patch)
2012-06-09 05:54 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (28.72 KB, patch)
2012-06-22 11:42 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-09 05:54:11 PDT
Created attachment 146697 [details] Patch
Pavel Feldman
Comment 2 2012-06-09 06:40:48 PDT
Comment on attachment 146697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146697&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:302 > + var oldFakeUILocation = /** @type {WebInspector.UILocation} */ this._uiLocations.get(this._fakeRawLocation); Isn't this the same as this._primaryUILocation ? > Source/WebCore/inspector/front-end/BreakpointManager.js:303 > + if (oldFakeUILocation) { Can it be 0? > Source/WebCore/inspector/front-end/BreakpointManager.js:360 > + if (this._enabled && this._primaryUILocation.uiLocationToRawLocation()) { This little twist changes the way breakpoint manager interacts with the debugger. I would add a comment. And I don't think I like it anyways. > Source/WebCore/inspector/front-end/DebuggerModel.js:138 > + if (rawLocation.scriptId) { I hate to say it, but I feel like debugging capabilities in the snippet editor are not worth making the underlying models so much more complex.
Vsevolod Vlasov
Comment 3 2012-06-22 11:42:07 PDT
Created attachment 149075 [details] Patch
Vsevolod Vlasov
Comment 4 2012-07-02 05:52:13 PDT
Committed r121673: <http://trac.webkit.org/changeset/121673>
Note You need to log in before you can comment on or make changes to this bug.