Bug 87086

Summary: PAGE_POPUP: window.setValueAndClosePopup should be moved to a per-context property of DOMWindow.
Product: WebKit Reporter: Kent Tamura <tkent>
Component: WebCore JavaScriptAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86555, 87185    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
WIP 2
none
Patch
none
Patch for landing none

Kent Tamura
Reported 2012-05-21 23:29:54 PDT
[V8] PAGE_POPUP: window.setValueAndClosePopup should be a per-context function
Attachments
WIP (21.95 KB, patch)
2012-05-22 02:52 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
WIP 2 (22.48 KB, patch)
2012-05-22 02:55 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (24.87 KB, patch)
2012-05-22 23:57 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.20 KB, patch)
2012-05-24 22:43 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-05-22 02:52:11 PDT
Created attachment 143245 [details] WIP
Kent Tamura
Comment 2 2012-05-22 02:55:31 PDT
Created attachment 143246 [details] WIP 2
Hajime Morrita
Comment 3 2012-05-22 21:01:50 PDT
Comment on attachment 143246 [details] WIP 2 View in context: https://bugs.webkit.org/attachment.cgi?id=143246&action=review Maybe we could define window.popupController attribute instead of function. Then popup window can turn to be a supplemental module. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:368 > + if ($attrExt->{"V8EnablePerContext"}) { EnableAtRuntime and EnablePerContext should be mutually exclusive. So else if would be preferred.
Kent Tamura
Comment 4 2012-05-22 22:58:05 PDT
> Maybe we could define window.popupController attribute instead of function. > Then popup window can turn to be a supplemental module. It make sense. It's extensible and I don't need to touch a Perl code though we need to add one more C++ class and IDL.
Kent Tamura
Comment 5 2012-05-22 23:57:33 PDT
Created attachment 143479 [details] Patch
Adam Barth
Comment 6 2012-05-23 10:50:58 PDT
Comment on attachment 143479 [details] Patch Should we add a test that pagePopupController doesn't appear on the default Window object by mistake?
Hajime Morrita
Comment 7 2012-05-23 17:13:46 PDT
(In reply to comment #6) > (From update of attachment 143479 [details]) > Should we add a test that pagePopupController doesn't appear on the default Window object by mistake? That sounds nice. Just having a test which checks pagePopController will be sufficient. If we have a way to enable it from testing API, it would be greater. But that is another story.
Kent Tamura
Comment 8 2012-05-24 22:43:06 PDT
Created attachment 143980 [details] Patch for landing Add a simple test
WebKit Review Bot
Comment 9 2012-05-24 23:50:55 PDT
Comment on attachment 143980 [details] Patch for landing Clearing flags on attachment: 143980 Committed r118482: <http://trac.webkit.org/changeset/118482>
WebKit Review Bot
Comment 10 2012-05-24 23:51:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.