Bug 87035

Summary: !HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, eric, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2012-05-21 11:36:24 PDT
!HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility
Attachments
Patch (9.06 KB, patch)
2012-05-21 11:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.68 KB, patch)
2012-05-21 15:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.74 KB, patch)
2012-05-21 15:57 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.83 KB, patch)
2012-05-21 16:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.90 KB, patch)
2012-05-21 16:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-21 11:39:44 PDT
Presumably this is a chromium-only issue? :)
Adam Barth
Comment 2 2012-05-21 11:40:05 PDT
Created attachment 143067 [details] Patch
chris fleizach
Comment 3 2012-05-21 11:41:42 PDT
Comment on attachment 143067 [details] Patch looks ok
Early Warning System Bot
Comment 4 2012-05-21 11:54:02 PDT
Comment on attachment 143067 [details] Patch Attachment 143067 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12731700
Adam Barth
Comment 5 2012-05-21 11:54:38 PDT
> Presumably this is a chromium-only issue? :) It's likely to reduce the binary size on other ports that use !HAVE(ACCESSIBILITY) too.
Early Warning System Bot
Comment 6 2012-05-21 11:57:54 PDT
Comment on attachment 143067 [details] Patch Attachment 143067 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12736641
Adam Barth
Comment 7 2012-05-21 15:08:13 PDT
Created attachment 143110 [details] Patch for landing
Adam Barth
Comment 8 2012-05-21 15:08:56 PDT
This patch should remove the duplicate symbols.
Early Warning System Bot
Comment 9 2012-05-21 15:43:51 PDT
Comment on attachment 143110 [details] Patch for landing Attachment 143110 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12747180
Early Warning System Bot
Comment 10 2012-05-21 15:49:55 PDT
Comment on attachment 143110 [details] Patch for landing Attachment 143110 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12740569
Adam Barth
Comment 11 2012-05-21 15:50:40 PDT
Comment on attachment 143110 [details] Patch for landing Too tight. /me tries again.
Adam Barth
Comment 12 2012-05-21 15:57:02 PDT
Created attachment 143123 [details] Patch
Early Warning System Bot
Comment 13 2012-05-21 16:05:12 PDT
Comment on attachment 143123 [details] Patch Attachment 143123 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12738599
Adam Barth
Comment 14 2012-05-21 16:11:06 PDT
Created attachment 143125 [details] Patch
Early Warning System Bot
Comment 15 2012-05-21 16:17:42 PDT
Comment on attachment 143125 [details] Patch Attachment 143125 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12747194
Early Warning System Bot
Comment 16 2012-05-21 16:18:52 PDT
Comment on attachment 143125 [details] Patch Attachment 143125 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12742372
Adam Barth
Comment 17 2012-05-21 16:23:06 PDT
Created attachment 143126 [details] Patch
WebKit Review Bot
Comment 18 2012-05-21 22:46:01 PDT
Comment on attachment 143126 [details] Patch Clearing flags on attachment: 143126 Committed r117907: <http://trac.webkit.org/changeset/117907>
WebKit Review Bot
Comment 19 2012-05-21 22:46:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.