Bug 84376

Summary: [Chromium] Call memoryUsageMB directly
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-04-19 13:19:26 PDT
[Chromium] Call memoryUsageMB directly
Attachments
Patch (20.85 KB, patch)
2012-04-19 13:22 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (20.85 KB, patch)
2012-04-19 19:02 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (20.85 KB, patch)
2012-04-20 14:58 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-04-19 13:22:49 PDT
Created attachment 137964 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-04-19 13:24:00 PDT
This adds new files to WebKit, so we'll need to wait for the EWS bots to tell us if I screwed that part up.
Build Bot
Comment 3 2012-04-19 13:27:50 PDT
Comment on attachment 137964 [details] Patch Attachment 137964 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12442306
Early Warning System Bot
Comment 4 2012-04-19 13:30:22 PDT
Comment on attachment 137964 [details] Patch Attachment 137964 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12458029
Early Warning System Bot
Comment 5 2012-04-19 13:31:24 PDT
Comment on attachment 137964 [details] Patch Attachment 137964 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12428710
Build Bot
Comment 6 2012-04-19 13:39:52 PDT
Comment on attachment 137964 [details] Patch Attachment 137964 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12297418
Mark Pilgrim (Google)
Comment 7 2012-04-19 14:00:31 PDT
Well I guess that answers that question.
Eric Seidel (no email)
Comment 8 2012-04-19 14:13:53 PDT
Comment on attachment 137964 [details] Patch The EWS bots are sad.
Mark Pilgrim (Google)
Comment 9 2012-04-19 19:02:16 PDT
Created attachment 138025 [details] Patch
Kentaro Hara
Comment 10 2012-04-20 01:26:50 PDT
Comment on attachment 138025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138025&action=review > Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp:39 > +// Returns the current space allocated for the pagefile, in MB. > +// That is committed size for Windows and virtual memory size for POSIX Nit: Put this comment in the header file. Nit: The trailing period please. "for POSIX."
Mark Pilgrim (Google)
Comment 11 2012-04-20 14:58:13 PDT
Created attachment 138172 [details] Patch
Mark Pilgrim (Google)
Comment 12 2012-04-20 14:58:40 PDT
Comment on attachment 138172 [details] Patch Nits addressed.
Kentaro Hara
Comment 13 2012-04-20 15:04:21 PDT
Comment on attachment 138172 [details] Patch OK
WebKit Review Bot
Comment 14 2012-04-20 16:31:43 PDT
Comment on attachment 138172 [details] Patch Clearing flags on attachment: 138172 Committed r114797: <http://trac.webkit.org/changeset/114797>
WebKit Review Bot
Comment 15 2012-04-20 16:31:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.