Bug 84318

Summary: AsyncFileSystem::openFileSystem is missing parameters
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: PlatformAssignee: Leo Yang <leo.yang>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, andersca, charles.wei, eric, rwlbuis, staikos, tonikitoo, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82156    
Attachments:
Description Flags
Patch eric: review-

Leo Yang
Reported 2012-04-18 22:49:53 PDT
AsyncFileSystem::openFileSystem should take more parameters (SecurityOrigin and file system size) from LocalFileSystem::requestFileSystem. These parameter are required when opening a filesystem.
Attachments
Patch (9.58 KB, patch)
2012-04-18 23:15 PDT, Leo Yang 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-04-18 23:15:40 PDT
Created attachment 137850 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-19 16:16:53 PDT
Comment on attachment 137850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137850&action=review > Source/WebCore/platform/AsyncFileSystem.cpp:67 > +void AsyncFileSystem::openFileSystem(ScriptExecutionContext*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks) ScriptExecutationContext is not a platofrm concept. I believe this is a layering violation. > Source/WebCore/platform/gtk/AsyncFileSystemGtk.cpp:50 > +void AsyncFileSystem::openFileSystem(SecurityOrigin*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks) Similarly, I believe this to be a layering violation.
Note You need to log in before you can comment on or make changes to this bug.