Bug 83041

Summary: Fix getFilterOutsets parameter types in RenderLayer
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jchaffraix, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 82535    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2012-04-03 09:42:31 PDT
getFilterOutsets was changed to take integer arguments in r112475 but RenderLater wasn't updated.
Attachments
Patch (2.49 KB, patch)
2012-04-03 10:06 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.22 KB, patch)
2012-04-04 12:19 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-04-03 10:06:54 PDT
Created attachment 135351 [details] Patch
Julien Chaffraix
Comment 2 2012-04-03 18:09:39 PDT
Comment on attachment 135351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135351&action=review > Source/WebCore/rendering/RenderLayer.cpp:4157 > // filtered areas with the outsets if we know that the filter is going to render in hardware. Above there are tons of implicit conversion due to calculateLayerBounds returning an IntRect, could we make those explicit?
Emil A Eklund
Comment 3 2012-04-03 20:54:13 PDT
(In reply to comment #2) > (From update of attachment 135351 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135351&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:4157 > > // filtered areas with the outsets if we know that the filter is going to render in hardware. > > Above there are tons of implicit conversion due to calculateLayerBounds returning an IntRect, could we make those explicit? That seems like a good idea, I'll go through them all tomorrow and make it explicit where it makes sense. Thanks!
Emil A Eklund
Comment 4 2012-04-04 12:19:24 PDT
Created attachment 135649 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-04 14:06:28 PDT
Comment on attachment 135649 [details] Patch for landing Clearing flags on attachment: 135649 Committed r113236: <http://trac.webkit.org/changeset/113236>
WebKit Review Bot
Comment 6 2012-04-04 14:06:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.