Bug 82871

Created attachment 135051 [details] Patch

Comment on attachment 135051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135051&action=review You need to update Source/*/Configuration/FeatureDefines.xcconfig, WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops, and Source/cmake/OptionsEfl.cmake. > Tools/Scripts/build-webkit:190 > + define => "ENABLE_DATALIST", default => isBlackBerry(), value => \$datalistSupport }, I'm not sure if Blackberry uses this script. > LayoutTests/fast/forms/datalist/datalist-nonoption-child.html:4 > +<script src="../../fast/js/resources/js-test-pre.js"></script> ../../js/resource/js-test-pre.js ?

Created attachment 135057 [details] Patch

Comment on attachment 135057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135057&action=review You need to touch LayoutTests/platform/chromium/test_expectations.txt too. > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:82 > Value="ENABLE_DATALIST" > - PerformEnvironmentSet="true" > + PerformEnvironmentSet="false" Do not change PerformEnvironentSet. What you need to do is to make Value empty.

Created attachment 135061 [details] Patch

Comment on attachment 135061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135061&action=review > LayoutTests/ChangeLog:9 > + We should disable ENABLE_DATALIST so we can show the fallback content when we don't have a UI. > + Moved datalist tests into directory fast/forms/datalist and added it to Skipped files. I think the rationale should be in the top-level ChangeLog. Also, we should say the main reason is incompleteness. - We need platform-dependent implementation, and non-BlackBerry platforms don't have it. - We need to hide the content of <datalist>, but it is shown for now. We had better announce this change in webkit-dev.

Created attachment 135269 [details] Patch

Comment on attachment 135269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135269&action=review Please announce this change to webkit-dev. > LayoutTests/platform/chromium/test_expectations.txt:1080 > -BUGCR20226 : fast/forms/datalist.html = TEXT > -BUGCR20226 : fast/forms/input-list.html = FAIL > -BUGCR20226 : fast/forms/input-selectedoption.html = FAIL > +BUGCR20226 : fast/forms/datalist/datalist.html = TEXT > +BUGCR20226 : fast/forms/datalist/input-list.html = FAIL > +BUGCR20226 : fast/forms/datalist/input-selectedoption.html = FAIL You can write this as BUCR20226 : fast/forms/datalist/ = PASS FAIL

Created attachment 135278 [details] Patch

Comment on attachment 135278 [details] Patch Clearing flags on attachment: 135278 Committed r113137: <http://trac.webkit.org/changeset/113137>

All reviewed patches have been landed. Closing bug.

This change appears to have caused platform/mac/fast/forms/input-list-button-size.html to fail on all of the Mac bots. The build before this change: http://build.webkit.org/builders/Lion%20Release%20%28Tests%29/builds/7220 And the first build with this change: http://build.webkit.org/builders/Lion%20Release%20%28Tests%29/builds/7221 Filing a new bug now.

Broken layout test --> https://bugs.webkit.org/show_bug.cgi?id=83207

(In reply to comment #2) > (From update of attachment 135051 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135051&action=review > > You need to update Source/*/Configuration/FeatureDefines.xcconfig, WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops, and Source/cmake/OptionsEfl.cmake. > > > Tools/Scripts/build-webkit:190 > > + define => "ENABLE_DATALIST", default => isBlackBerry(), value => \$datalistSupport }, > > I'm not sure if Blackberry uses this script. Better late than never, I can tell you that we do use this script :) > > > LayoutTests/fast/forms/datalist/datalist-nonoption-child.html:4 > > +<script src="../../fast/js/resources/js-test-pre.js"></script> > > ../../js/resource/js-test-pre.js ?