Bug 81212

Summary: Enable animVal support for SVGNumber
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 12437    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch rwlbuis: review+

Nikolas Zimmermann
Reported 2012-03-15 05:52:31 PDT
Enable animVal support for SVGNumber. It turns out we only have test cases in svg/animations covering AnimatedNumber animations for CSS properties like 'opacity'. Animating eg. SVGStopElements "offset" attribute needs to be tested as well (SVG DOM properties).
Attachments
Patch (15.29 KB, patch)
2012-03-15 06:02 PDT, Nikolas Zimmermann 		rwlbuis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2012-03-15 06:02:56 PDT
Created attachment 132028 [details] Patch
Rob Buis
Comment 2 2012-03-15 07:09:05 PDT
Comment on attachment 132028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132028&action=review LGTM. > Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h:2 > + * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. I think we always use 2010, 2011, 2012 style in our own files, maybe check. If we already break this style in our SVG contributions then this patch should not be the one fixing that, but we should discuss making a patch to use one style in future.
Nikolas Zimmermann
Comment 3 2012-03-15 07:10:16 PDT
(In reply to comment #2) > I think we always use 2010, 2011, 2012 style in our own files, maybe check. If we already break this style in our SVG contributions then this patch should not be the one fixing that, but we should discuss making a patch to use one style in future. Good idea, can you ask around?
Nikolas Zimmermann
Comment 4 2012-03-15 07:13:56 PDT
Committed r110841: <http://trac.webkit.org/changeset/110841>
Note You need to log in before you can comment on or make changes to this bug.