Bug 80931

Summary: flexbox's computePreferredLogicalWidth needs to take multiline into account
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Chang
Reported 2012-03-12 19:53:53 PDT
flexbox's computePreferredLogicalWidth needs to take multiline into account
Attachments
Patch (72.99 KB, patch)
2012-03-12 19:55 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (72.88 KB, patch)
2012-03-13 09:44 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-03-12 19:55:23 PDT
Created attachment 131498 [details] Patch
Ojan Vafai
Comment 2 2012-03-12 20:07:14 PDT
Comment on attachment 131498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131498&action=review cq- just to give you a chance to address the nits if you want to. > Source/WebCore/rendering/RenderFlexibleBox.cpp:192 > + if (!isMultiline()) Nit: here and below i'd prefer to invert the if statement. > Source/WebCore/rendering/RenderFlexibleBox.cpp:861 > + if (!isColumnFlow() && crossAxisLength().isAuto()) s/crossAxisLength/logicalHeight ? Not sure if that's better or worse.
Tony Chang
Comment 3 2012-03-13 09:44:55 PDT
Created attachment 131641 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-03-13 11:17:18 PDT
Comment on attachment 131641 [details] Patch for landing Clearing flags on attachment: 131641 Committed r110583: <http://trac.webkit.org/changeset/110583>
WebKit Review Bot
Comment 5 2012-03-13 11:17:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.