Bug 80487

Summary: Move NotificationContents into Notification
Product: WebKit Reporter: Jon Lee <jonlee>
Component: DOMAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: atwilson, dglazkov, sam, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 80472    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch jianli: review+

Jon Lee
Reported 2012-03-06 21:50:46 PST
Splitting out the data members for text notifications is unnecessary. Move those data members (title, body, URL) back into Notification, and remove NotificationContents from WebCore. <rdar://problem/10965519>
Attachments
Patch (20.56 KB, patch)
2012-03-07 17:46 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (20.67 KB, patch)
2012-03-07 21:22 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (27.64 KB, patch)
2012-03-07 22:44 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (28.64 KB, patch)
2012-03-10 11:03 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (28.49 KB, patch)
2012-03-10 13:18 PST, Jon Lee 		jianli: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2012-03-07 17:46:21 PST
Created attachment 130737 [details] Patch
Build Bot
Comment 2 2012-03-07 17:57:30 PST
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11862037
Early Warning System Bot
Comment 3 2012-03-07 18:52:57 PST
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11863083
WebKit Review Bot
Comment 4 2012-03-07 19:58:25 PST
Comment on attachment 130737 [details] Patch Attachment 130737 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11865076
Jon Lee
Comment 5 2012-03-07 21:22:14 PST
Created attachment 130761 [details] Patch
Early Warning System Bot
Comment 6 2012-03-07 21:40:42 PST
Comment on attachment 130761 [details] Patch Attachment 130761 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11866121
WebKit Review Bot
Comment 7 2012-03-07 21:43:26 PST
Comment on attachment 130761 [details] Patch Attachment 130761 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11861150
Jon Lee
Comment 8 2012-03-07 22:44:05 PST
Created attachment 130772 [details] Patch
Jon Lee
Comment 9 2012-03-10 11:03:19 PST
Created attachment 131177 [details] Patch
Jon Lee
Comment 10 2012-03-10 13:18:50 PST
Created attachment 131186 [details] Patch
Jian Li
Comment 11 2012-03-15 11:31:47 PDT
Comment on attachment 131186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review > Source/WebCore/notifications/Notification.h:77 > + KURL iconURL() { return m_icon; } Please add const modifier. > Source/WebCore/notifications/Notification.h:79 > + void setTitle(const String& title) { m_title = title; } It seems that none is accessing setTitle and setBody now. Will they be used in the future patch?
Jon Lee
Comment 12 2012-03-15 11:42:07 PDT
(In reply to comment #11) > (From update of attachment 131186 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131186&action=review > > > Source/WebCore/notifications/Notification.h:77 > > + KURL iconURL() { return m_icon; } > > Please add const modifier. Sure. > > > Source/WebCore/notifications/Notification.h:79 > > + void setTitle(const String& title) { m_title = title; } > > It seems that none is accessing setTitle and setBody now. Will they be used in the future patch? Not at this point. I can remove.
Jon Lee
Comment 13 2012-03-15 16:07:45 PDT
Committed r110903: <http://trac.webkit.org/changeset/110903>
Note You need to log in before you can comment on or make changes to this bug.