Bug 78333

Summary: Rename classes defined in ContentInclusionSelector to more suitable names which match the spec
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, rakuco, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63606    
Attachments:
Description Flags
rename
none
update. none

Hayato Ito
Reported 2012-02-10 01:11:12 PST
The current class names defined in ContentInclusionSelector are not intuitive. It would be nice that we have more intuitive names which use the terms defined in the spec.
Attachments
rename (48.44 KB, patch)
2012-02-10 03:22 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
update. (53.72 KB, patch)
2012-02-10 03:46 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-02-10 01:20:00 PST
How about this? ContentInclusionSelector -> HostChildNodesSelector ShadowInclusionSet -> HostChildNodesSelectionSet ShadowInclusionList -> HostChildNodesSelectionList ShadowInclusion -> HostChildNodesSelection If there is no objection, let me rename.
Hajime Morrita
Comment 2 2012-02-10 02:09:04 PST
"Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow.
Hayato Ito
Comment 3 2012-02-10 02:35:39 PST
Okay. Let me rename as follows: ContentInclusionSelector -> HTMLContentSelector ShadowInclusionSet -> HTMLContentSelectionSet ShadowInclusionList -> HTMLContentSelectionList ShadowInclusion -> HTMLContentSelection I also rename member functions and variables to match the names. (In reply to comment #2) > "Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow.
Hayato Ito
Comment 4 2012-02-10 03:22:57 PST
Created attachment 126488 [details] rename
Hayato Ito
Comment 5 2012-02-10 03:46:38 PST
Created attachment 126493 [details] update.
Hayato Ito
Comment 6 2012-02-10 03:49:37 PST
Most renaming is done. The patch is reedy for review. Follow-up patch will do remaining renaming, such as renaming window.Internals binding.
Hayato Ito
Comment 7 2012-02-12 17:50:51 PST
Morrita-san, could you take a look?
WebKit Review Bot
Comment 8 2012-02-13 04:15:42 PST
Comment on attachment 126493 [details] update. Clearing flags on attachment: 126493 Committed r107558: <http://trac.webkit.org/changeset/107558>
WebKit Review Bot
Comment 9 2012-02-13 04:15:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.