Bug 77460

Summary: Remove CSSStyleDeclaration isElementStyleDeclaration bit
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-01-31 11:18:15 PST
Only style declarations with element parent are now inline style declarations. We can remove the bit and the associated logic.
Attachments
patch (8.46 KB, patch)
2012-01-31 11:23 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-01-31 11:23:06 PST
Created attachment 124782 [details] patch
WebKit Review Bot
Comment 2 2012-01-31 11:24:56 PST
Attachment 124782 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-01-31 11:29:36 PST
Comment on attachment 124782 [details] patch Me gusta.
Antti Koivisto
Comment 4 2012-02-03 09:42:18 PST
http://trac.webkit.org/changeset/106384
Note You need to log in before you can comment on or make changes to this bug.