Bug 77113

Summary: [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Web Template FrameworkAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, kevino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72854    
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2012-01-26 10:15:24 PST
As being mentioned at Bug 72854, there are some extra export annotation in WTFSTring.h which we can remove.
Attachments
Patch (3.54 KB, patch)
2012-01-27 10:40 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.56 KB, patch)
2012-01-27 11:14 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-01-27 10:40:47 PST
Created attachment 124334 [details] Patch
Darin Adler
Comment 2 2012-01-27 10:43:51 PST
Comment on attachment 124334 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124334&action=review > Source/JavaScriptCore/ChangeLog:8 > + * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes. To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time.
Hajime Morrita
Comment 3 2012-01-27 11:09:48 PST
Hi Darin, Thanks for your immediate review! > > Source/JavaScriptCore/ChangeLog:8 > > + * wtf/text/WTFString.h: Removed some redundant WTF_EXPORT_PRIVATE attributes. > > To be clear, we are not removing these because they are “redundant”. We are removing them because we do not need to export these functions at this time. That's right. I'll correct the explanation before land.
Hajime Morrita
Comment 4 2012-01-27 11:14:03 PST
Created attachment 124338 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-27 12:53:43 PST
Comment on attachment 124338 [details] Patch for landing Clearing flags on attachment: 124338 Committed r106143: <http://trac.webkit.org/changeset/106143>
WebKit Review Bot
Comment 6 2012-01-27 12:53:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.