Bug 76589

Summary: Assigning to Element.prefix should throw exception when using illegal characters
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76198    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2012-01-18 17:09:50 PST
Assigning to Element.prefix should throw exception when using illegal characters
Attachments
Patch (6.05 KB, patch)
2012-01-18 17:12 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (7.02 KB, patch)
2012-01-18 21:07 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (7.24 KB, patch)
2012-01-18 21:26 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-18 17:12:21 PST
Created attachment 123041 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-18 17:28:12 PST
Comment on attachment 123041 [details] Patch Um... I think we need at least 10x this many tests for this much code. :(
Adam Barth
Comment 3 2012-01-18 17:35:05 PST
Comment on attachment 123041 [details] Patch ok.
Adam Barth
Comment 4 2012-01-18 21:07:15 PST
Created attachment 123064 [details] Patch
Adam Barth
Comment 5 2012-01-18 21:26:29 PST
Created attachment 123068 [details] Patch
WebKit Review Bot
Comment 6 2012-01-18 23:39:56 PST
Comment on attachment 123068 [details] Patch Clearing flags on attachment: 123068 Committed r105388: <http://trac.webkit.org/changeset/105388>
WebKit Review Bot
Comment 7 2012-01-18 23:40:00 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 8 2012-01-19 15:57:50 PST
Comment on attachment 123064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123064&action=review > Source/WebCore/dom/Node.cpp:132 > +static bool isValidNameStartCharacter(UChar c) We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions?
Adam Barth
Comment 9 2012-01-19 16:01:28 PST
> We already have isValidNameStart and isValidNamePart functions in Document.cpp. Can we share those instead of adding new functions? Sure. Should we move the functions to QualifiedName.cpp at the same time? That seems like a more natural place for them to live.
Adam Barth
Comment 10 2012-01-19 16:02:37 PST
I filed Bug 76672 on this topic.
Note You need to log in before you can comment on or make changes to this bug.