Bug 76326

Summary: getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: CSSAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch tony: review+

Ojan Vafai
Reported 2012-01-13 18:48:00 PST
Summary: getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
Attachments
Patch (10.46 KB, patch)
2012-02-15 11:54 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-02-15 11:54:19 PST
Created attachment 127209 [details] Patch
Tony Chang
Comment 2 2012-02-15 12:05:29 PST
Comment on attachment 127209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127209&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1587 > + if (m_node && m_node->parentNode() && m_node->parentNode()->computedStyle() && style->flexItemAlign() == AlignAuto) I would put the style->flexItemAlign() == AlignAuto check first so we don't do all the other checks for other alignments.
Ojan Vafai
Comment 3 2012-02-15 12:26:59 PST
Committed r107833: <http://trac.webkit.org/changeset/107833>
Note You need to log in before you can comment on or make changes to this bug.