Bug 75896

Created attachment 121734 [details] Patch

Comment on attachment 121734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121734&action=review > LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html:1 > +<style> Are you intentionally testing quirks mode? If not, you should have DOCTYPE here. > LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html:12 > + <div class="blockTest" style="height:0px"> > + <div style="height:400px; background-color:grey">This content should be masked with a soft glow.</div> Nit: space between ":" and values. > LayoutTests/css3/calc/block-mask-overlay-image-outset.html:1 > +<style> Ditto.

Created attachment 121795 [details] Patch for landing

Thanks for the review Ryosuke - as discussed on IRC I've fixed the nits and CQ'd the patch.

Comment on attachment 121795 [details] Patch for landing Clearing flags on attachment: 121795 Committed r104543: <http://trac.webkit.org/changeset/104543>

All reviewed patches have been landed. Closing bug.

This patch causes assertion in debug tests on Snow Leopard: ASSERTION FAILED: isfinite(num) /b/build/slave/webkit-mac-latest-dbg/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../css/CSSPrimitiveValue.cpp(190) : WebCore::CSSPrimitiveValue::CSSPrimitiveValue(double, WebCore::CSSPrimitiveValue::UnitTypes) [986:2307:605478904055:ERROR:process_util_posix.cc(138)] Received signal 11 0 DumpRenderTree 0x0f8cf9cf base::debug::StackTrace::StackTrace() + 63 1 DumpRenderTree 0x0f8cf96b base::debug::StackTrace::StackTrace() + 43 2 DumpRenderTree 0x0ff54757 base::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, __darwin_ucontext*) + 295 3 libSystem.B.dylib 0x9651a05b _sigtramp + 43 4 ??? 0xffffffff 0x0 + 4294967295 5 DumpRenderTree 0x11d4e61e WebCore::CSSPrimitiveValue::CSSPrimitiveValue(double, WebCore::CSSPrimitiveValue::UnitTypes) + 78 6 DumpRenderTree 0x11dfcd52 WebCore::CSSPrimitiveValue::create(double, WebCore::CSSPrimitiveValue::UnitTypes) + 98 7 DumpRenderTree 0x11e3c940 WebCore::CSSValuePool::createValue(double, WebCore::CSSPrimitiveValue::UnitTypes) + 208 8 DumpRenderTree 0x11d188e7 WebCore::BorderImageQuadParseContext::commitBorderImageQuad() + 343 9 DumpRenderTree 0x11d059b4 WebCore::CSSParser::parseBorderImageQuad(WebCore::CSSParser::Units, WTF::RefPtr<WebCore::CSSPrimitiveValue>&) + 388 10 DumpRenderTree 0x11cf6688 WebCore::CSSParser::parseBorderImageWidth(WTF::RefPtr<WebCore::CSSPrimitiveValue>&) + 152 11 DumpRenderTree 0x11cf5d9c WebCore::CSSParser::parseBorderImage(int, WTF::RefPtr<WebCore::CSSValue>&) + 1324 12 DumpRenderTree 0x11cec89e WebCore::CSSParser::parseValue(int, bool) + 9630 13 DumpRenderTree 0x12beace7 cssyyparse(void*) + 13751 14 DumpRenderTree 0x11ce736e WebCore::CSSParser::parseSheet(WebCore::CSSStyleSheet*, WTF::String const&, int, WTF::HashMap<WebCore::CSSStyleRule*, WTF::RefPtr<WebCore::CSSRuleSourceData>, WTF::PtrHash<WebCore::CSSStyleRule*>, WTF::HashTraits<WebCore::CSSStyleRule*>, WTF::HashTraits<WTF::RefPtr<WebCore::CSSRuleSourceData> > >*) + 318 15 DumpRenderTree 0x11e342b0 WebCore::CSSStyleSheet::parseStringAtLine(WTF::String const&, bool, int) + 176 16 DumpRenderTree 0x11595159 WebCore::StyleElement::createSheet(WebCore::Element*, int, WTF::String const&) + 1097 17 DumpRenderTree 0x1159478f WebCore::StyleElement::process(WebCore::Element*) + 671 18 DumpRenderTree 0x11594c04 WebCore::StyleElement::finishParsingChildren(WebCore::Element*) + 148 19 DumpRenderTree 0x1167f1bd WebCore::HTMLStyleElement::finishParsingChildren() + 61 20 DumpRenderTree 0x11742dd7 WebCore::HTMLElementStack::popCommon() + 439 21 DumpRenderTree 0x11743087 WebCore::HTMLElementStack::pop() + 167 22 DumpRenderTree 0x1176a770 WebCore::HTMLTreeBuilder::processEndTag(WebCore::AtomicHTMLToken&) + 4672 23 DumpRenderTree 0x11766c0d WebCore::HTMLTreeBuilder::processToken(WebCore::AtomicHTMLToken&) + 253 24 DumpRenderTree 0x11765e13 WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken(WebCore::AtomicHTMLToken&) + 115 25 DumpRenderTree 0x11765cf5 WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) + 117 26 DumpRenderTree 0x1173aa55 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) + 869 27 DumpRenderTree 0x1173a3ed WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) + 237 28 DumpRenderTree 0x1173b638 WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) + 360 29 DumpRenderTree 0x1141a1ab WebCore::DecodedDataDocumentParser::flush(WebCore::DocumentWriter*) + 171 30 DumpRenderTree 0x121251c1 WebCore::DocumentWriter::endIfNotLoadingMainResource() + 209 31 DumpRenderTree 0x12124743 WebCore::DocumentWriter::end() + 67 32 DumpRenderTree 0x12109de2 WebCore::DocumentLoader::finishedLoading() + 114 33 DumpRenderTree 0x1213ce05 WebCore::FrameLoader::finishedLoading() + 101 34 DumpRenderTree 0x1215cb4b WebCore::MainResourceLoader::didFinishLoading(double) + 315 35 DumpRenderTree 0x1217d448 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) + 200 36 DumpRenderTree 0x0fa1c1f9 WebCore::ResourceHandleInternal::didFinishLoading(WebKit::WebURLLoader*, double) + 265 37 DumpRenderTree 0x1323bf3f webkit_glue::WebURLLoaderImpl::Context::OnCompletedRequest(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&) + 1071 38 DumpRenderTree 0x133a2d0d (anonymous namespace)::RequestProxy::NotifyCompletedRequest(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&) + 109 39 DumpRenderTree 0x133a3535 base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>::Run((anonymous namespace)::RequestProxy*, net::URLRequestStatus const&, std::string const&, base::TimeTicks const&) + 213 40 DumpRenderTree 0x133a3436 base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>, void ()((anonymous namespace)::RequestProxy* const&, net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>::MakeItSo(base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>, (anonymous namespace)::RequestProxy* const&, net::URLRequestStatus const&, std::string const&, base::TimeTicks const&) + 150 41 DumpRenderTree 0x133a3375 base::internal::Invoker<4, base::internal::BindState<base::internal::RunnableAdapter<void ((anonymous namespace)::RequestProxy::*)(net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>, void ()((anonymous namespace)::RequestProxy*, net::URLRequestStatus const&, std::string const&, base::TimeTicks const&), void ()((anonymous namespace)::RequestProxy*, net::URLRequestStatus, std::string, base::TimeTicks)>, void ()((anonymous namespace)::RequestProxy*, net::URLRequestStatus const&, std::string const&, base::TimeTicks const&)>::Run(base::internal::BindStateBase*) + 229 42 DumpRenderTree 0x0ff02b9b base::Callback<void ()()>::Run() const + 75 43 DumpRenderTree 0x0ff00495 MessageLoop::RunTask(base::PendingTask const&) + 1125 44 DumpRenderTree 0x0ff006a1 MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) + 97 45 DumpRenderTree 0x0ff008d8 MessageLoop::DoWork() + 312 46 DumpRenderTree 0x0fe80f5b base::MessagePumpCFRunLoopBase::RunWork() + 107 47 DumpRenderTree 0x0fe80652 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 50 48 CoreFoundation 0x9739242b __CFRunLoopDoSources0 + 1563 49 CoreFoundation 0x9738feef __CFRunLoopRun + 1071 50 CoreFoundation 0x9738f3c4 CFRunLoopRunSpecific + 452 51 CoreFoundation 0x9738f1f1 CFRunLoopRunInMode + 97 52 HIToolbox 0x96b5ee04 RunCurrentEventLoopInMode + 392 53 HIToolbox 0x96b5ebb9 ReceiveNextEventCommon + 354 54 HIToolbox 0x96b5ea3e BlockUntilNextEventMatchingListInMode + 81 55 AppKit 0x9345f595 _DPSNextEvent + 847 56 AppKit 0x9345edd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156 57 AppKit 0x934211f3 -[NSApplication run] + 821 58 DumpRenderTree 0x0fe81c7e base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 350 59 DumpRenderTree 0x0fe80c4d base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 189 60 DumpRenderTree 0x0feffce3 MessageLoop::RunInternal() + 291 61 DumpRenderTree 0x0fefeffb MessageLoop::RunHandler() + 43

Reopen the bug since the patch was rolled out.

Weird. I could not repro on my Mac (using the chromium port of WebKit), and neither could Noel Gordon. I ran a chromium try job on the mac_layout server, and it passed there too: 2012-01-11 21:08:19,473 13851 worker.py:186 DEBUG worker/1 css3/calc/block-mask-overlay-image-outset.html passed full log is here, but it may not live forever: http://build.chromium.org/p/tryserver.chromium/builders/mac_layout/builds/285/steps/webkit_tests/logs/stdio I reckon what I'll do is land a test_expectations for it to PASS CRASH on mac, and see what it does this time.

Created attachment 122165 [details] Patch

Comment on attachment 122165 [details] Patch Clearing flags on attachment: 122165 Committed r104794: <http://trac.webkit.org/changeset/104794>

All reviewed patches have been landed. Closing bug.