Bug 75411

Summary: Enable the [Supplemental] IDL on GTK/GObject
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebKitGTKAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
WIP patch to see if build passes none

Kentaro Hara
Reported 2011-12-31 16:47:16 PST
We have enabled the [Supplemental] IDL on Chromium, AppleWebKit, GTK, Qt, Efl and WinCE, and are planning to enable it on all platforms (Meta bug 72138). In this bug, we enable it on GTK/GObject.
Attachments
WIP patch to see if build passes (5.26 KB, patch)
2012-01-01 01:38 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-01-01 01:38:23 PST
Created attachment 120843 [details] WIP patch to see if build passes
Adam Barth
Comment 2 2012-01-02 10:42:15 PST
Comment on attachment 120843 [details] WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120843&action=review > Source/WebCore/bindings/gobject/GNUmakefile.am:467 > + $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $(WebCore)/bindings/scripts/generate-bindings.pl --include $(WebCore)/dom --include $(WebCore)/html --include $(WebCore)/css --include $(WebCore)/page --include $(WebCore)/xml --include $(WebCore)/svg --outputDir "$(GENSOURCES_WEBKIT)" --defines "LANGUAGE_GOBJECT=1 $(gdom_feature_defines)" --generator GObject --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $< I'm surprised that these includes aren't broken out into a variable, but I see that's how this script worked before.
WebKit Review Bot
Comment 3 2012-01-02 17:25:07 PST
Comment on attachment 120843 [details] WIP patch to see if build passes Clearing flags on attachment: 120843 Committed r103920: <http://trac.webkit.org/changeset/103920>
WebKit Review Bot
Comment 4 2012-01-02 17:25:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.