Bug 75394

Summary: “Formatted Diff” view mangles non-ASCII characters
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, aroben, bdakin, darin, dbates, ddkilzer, haraken, mmaxfield, mrobinson, pknight, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://bugs.webkit.org/attachment.cgi?id=120812&action=prettypatch
See Also: https://bugs.webkit.org/show_bug.cgi?id=238630
Attachments:
Description Flags
Screenshot none

mitz
Reported 2011-12-30 12:21:35 PST
To reproduce, compare <https://bugs.webkit.org/attachment.cgi?id=120812&action=prettypatch> to <https://bugs.webkit.org/attachment.cgi?id=120812>. Notice that every apostrophe in the latter appears as â in the former. The plain diff is encoded as and served as UTF-8, with the apostrophe encoded as E2 80 99. In the formatted diff, each on of those bytes appears to have been interpreted as Latin-1 and then encoded as UTF-8, resulting in the sequence C3 A2 C2 80 C2 99.
Attachments
Screenshot (181.24 KB, image/jpeg)
2022-03-31 21:30 PDT, Myles C. Maxfield 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-03-21 23:22:06 PDT
Bugzilla.pm: > sub init_page { > (binmode STDOUT, ':utf8') if Bugzilla->params->{'utf8'}; attachment.cgi sub prettyPatch: > open2(\*OUT, \*IN, "/usr/bin/ruby", "-I", "PrettyPatch", "PrettyPatch/prettify.rb", "--html-exceptions"); > $ENV{'PATH'} = $orig_path; > print IN $attachment->data; > close(IN); > while (<OUT>) { > print; > } > close(OUT); I guess OUT works as binary, and "print" converts a binary line to UTF-8 because of binmode. Probably utf8::decode($_); before print fixes this?
Martin Robinson
Comment 2 2013-07-09 10:07:56 PDT
*** This bug has been marked as a duplicate of bug 45760 ***
mitz
Comment 3 2013-09-12 00:10:28 PDT
This is not fixed.
Myles C. Maxfield
Comment 4 2022-03-31 21:29:49 PDT
The apostrophes look correct to me now. Attaching screenshot.
Myles C. Maxfield
Comment 5 2022-03-31 21:30:08 PDT
Created attachment 456319 [details] Screenshot
mitz
Comment 6 2022-03-31 21:30:58 PDT
(In reply to Myles C. Maxfield from comment #4) > The apostrophes look correct to me now. Attaching screenshot. Good to see! Do you think this was fixed along with bug 238630?
Myles C. Maxfield
Comment 7 2022-04-01 10:27:36 PDT
Yes.
Myles C. Maxfield
Comment 8 2022-04-01 10:28:08 PDT
*** This bug has been marked as a duplicate of bug 238630 ***
Note You need to log in before you can comment on or make changes to this bug.