Bug 72008

Summary: A test for css parser: \r\n.
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69083    
Attachments:
Description Flags
newline with unicode - JavaScript test
none
updated test
none
updated patch v2. none

Szilard Ledan
Reported 2011-11-10 01:55:11 PST
The css number types (px, pt, cm, ...) can be specified escape sequences (px = \70\78,...).
Attachments
newline with unicode - JavaScript test (4.46 KB, patch)
2011-11-11 00:36 PST, Szilard Ledan 		no flags
DetailsFormatted DiffDiff
updated test (4.46 KB, patch)
2011-11-25 00:35 PST, Szilard Ledan 		no flags
DetailsFormatted DiffDiff
updated patch v2. (3.00 KB, patch)
2011-11-25 07:54 PST, Szilard Ledan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Szilard Ledan
Comment 1 2011-11-11 00:36:24 PST
Created attachment 114639 [details] newline with unicode - JavaScript test
Zoltan Herczeg
Comment 2 2011-11-24 05:56:47 PST
Hey Szilard, the name of the bug should be \r\n. And it seems to me that something is not working since you attached a layout dump not a text dump.
Szilard Ledan
Comment 3 2011-11-25 00:35:15 PST
Created attachment 116578 [details] updated test
Szilard Ledan
Comment 4 2011-11-25 07:54:23 PST
Created attachment 116619 [details] updated patch v2.
Darin Adler
Comment 5 2011-11-30 10:48:36 PST
Comment on attachment 116619 [details] updated patch v2. This test is OK, but not great. The output is confusing because both the rules and expected result seem to match. I’d love to see a clearer version.
Darin Adler
Comment 6 2011-11-30 10:49:21 PST
Comment on attachment 116619 [details] updated patch v2. I also think this is too little for a single test to cover. We should come up with a way to cover many different CSS parser test cases with a single test instead of having a test that focuses on only this one issue.
WebKit Review Bot
Comment 7 2011-11-30 18:10:52 PST
Comment on attachment 116619 [details] updated patch v2. Clearing flags on attachment: 116619 Committed r101581: <http://trac.webkit.org/changeset/101581>
WebKit Review Bot
Comment 8 2011-11-30 18:10:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.