Bug 70780

Summary: flex-align:stretch + max-height needs to clamp to max-height and position appropriately
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch hyatt: review+

Ojan Vafai
Reported 2011-10-24 16:49:37 PDT
See www-style discussion for the resolution of where it should be positioned: http://lists.w3.org/Archives/Public/www-style/2011Oct/0698.html
Attachments
Patch (8.63 KB, patch)
2011-11-17 13:56 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (8.53 KB, patch)
2011-11-17 16:10 PST, Tony Chang 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-11-17 13:56:29 PST
Created attachment 115669 [details] Patch
Ojan Vafai
Comment 2 2011-11-17 14:12:04 PST
Comment on attachment 115669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115669&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:720 > + Length logicalHeight = isHorizontalFlow() ? child->style()->height() : child->style()->width(); Nit: s/logicalHeight/crossAxisExtent
Tony Chang
Comment 3 2011-11-17 16:10:12 PST
Created attachment 115704 [details] Patch
Tony Chang
Comment 4 2011-11-17 16:11:22 PST
(In reply to comment #2) > (From update of attachment 115669 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115669&action=review > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:720 > > + Length logicalHeight = isHorizontalFlow() ? child->style()->height() : child->style()->width(); > > Nit: s/logicalHeight/crossAxisExtent I switch to using logical height for all of this code since it only applies to row flexing.
Ojan Vafai
Comment 5 2011-11-18 00:16:34 PST
Comment on attachment 115704 [details] Patch LGTM
Dave Hyatt
Comment 6 2011-11-29 11:01:27 PST
Comment on attachment 115704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115704&action=review r=me > Source/WebCore/rendering/RenderBox.cpp:1805 > + // In the case of columns that have a strech alignment, we go ahead and layout at the Typo. strech should be stretch.
Tony Chang
Comment 7 2011-11-29 11:08:04 PST
Committed r101399: <http://trac.webkit.org/changeset/101399>
Note You need to log in before you can comment on or make changes to this bug.