Bug 70416

Summary: NRWT doesn't support ORWT's --root option, but should
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, ojan, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch none

Adam Roben (:aroben)
Reported 2011-10-19 07:13:33 PDT
ORWT supports a --root flag that tells it where to find the built copy of WebKit. NRWT should support this option, too.
Attachments
Patch (5.43 KB, patch)
2011-10-24 11:31 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-10-19 07:14:08 PDT
<rdar://problem/10310764>
Eric Seidel (no email)
Comment 2 2011-10-24 11:31:04 PDT
Created attachment 112217 [details] Patch
Eric Seidel (no email)
Comment 3 2011-10-24 11:31:26 PDT
Please let me know if this behaves as you would expect it should.
Adam Roben (:aroben)
Comment 4 2011-10-24 11:38:49 PDT
Comment on attachment 112217 [details] Patch The behavior of the test looks right to me. I'll let an NRWT aficionado r+ the patch.
WebKit Review Bot
Comment 5 2011-10-24 13:53:22 PDT
Comment on attachment 112217 [details] Patch Clearing flags on attachment: 112217 Committed r98279: <http://trac.webkit.org/changeset/98279>
WebKit Review Bot
Comment 6 2011-10-24 13:53:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.