Bug 70229
| Summary: | [Curl] ResourceHandleManager::startJob() for Data URLs is missing deref() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jens <jens.rosenboom> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Minor | CC: | basuke |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 173991 | ||
| Bug Blocks: | |||
Jens
Hello All,
IMHO a deref() is missing for asynchronous jobs with data:// URLs.
In function ResourceHandleManager.cpp:
- function add() calls ref() on a new job and adds it to a list
- function startScheduledJobs() takes it from that list and calls startJob()
- function startJob() calls handleDataUrl() (for data:// URLs)
Shouldn't startJob() call deref() after handleDataUrl() returns?
Best regards,
Jens
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Basuke Suzuki
Because of the new architecture, this bug is invalid.
Basuke Suzuki
https://bugs.webkit.org/show_bug.cgi?id=173991