Bug 67855

Summary: Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dpranke, eric, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64812    
Attachments:
Description Flags
fixes the bug none

Ryosuke Niwa
Reported 2011-09-09 10:15:55 PDT
Some ports use RunWebKitTests instead of NewRunWebKitTests to run tests, and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
Attachments
fixes the bug (2.82 KB, patch)
2011-09-09 10:17 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-09-09 10:17:17 PDT
Created attachment 106885 [details] fixes the bug
Ryosuke Niwa
Comment 2 2011-09-09 10:38:16 PDT
We really need this patch landed ASAP. Right now, this bug is making Mac bots red.
Dirk Pranke
Comment 3 2011-09-09 10:54:34 PDT
Comment on attachment 106885 [details] fixes the bug Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ?
Ryosuke Niwa
Comment 4 2011-09-09 11:07:38 PDT
(In reply to comment #3) > (From update of attachment 106885 [details]) > Shouldn't we switch the ports that are using RunWebKitTests to NewRunWebKitTests instead of modifying both evaluateCommands ? We can't because some of bots are still in the process of transitioning and we may need to move it back.
Dirk Pranke
Comment 5 2011-09-09 11:16:23 PDT
Comment on attachment 106885 [details] fixes the bug Per conversation over IRC, some (most?) bots are invoking NRWT through the run-webkit-tests wrapper, and so they we need to update the parser in the wrapper command. R+. We really need to consolidate these things and finish the cutover though ...
Ryosuke Niwa
Comment 6 2011-09-09 11:20:50 PDT
Comment on attachment 106885 [details] fixes the bug Clearing flags on attachment: 106885 Committed r94868: <http://trac.webkit.org/changeset/94868>
Ryosuke Niwa
Comment 7 2011-09-09 11:20:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.