Bug 64472

The relevant code in ORWT is here: <http://trac.webkit.org/browser/trunk/Tools/Scripts/old-run-webkit-tests?rev=90125#L544>.

Thank you for the report. Should be very easy to fix.

The support is all written, but it must be broken somehow. Someone with python familiarity and a windows build of webkit should be able to debug this. I don't have a windows build handy. :( http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L276 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L236 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L253

I will take a look. In theory, you should be able to verify this with --platform mock-win and not need the build around.

(In reply to comment #4) > I will take a look. In theory, you should be able to verify this with --platform mock-win and not need the build around. Er, scratch that, obviously it won't work for feature detection.

If someone with a windows box could tell me what DRT output looks like I can easily unittest (and hopefully fix) this code without needing to set up a windows machine: Basically I just need the output from: ./DumpRenderTree --print-supported-features 2>&1 It would be nice to know if --print-supported-features is actually writing to stderr, because I'd like to get rid of the 2>&1 nonsense if possible. :)

It looks like it does not print to stderr: if (printSupportedFeatures) { BOOL acceleratedCompositingAvailable; standardPreferences->acceleratedCompositingEnabled(&acceleratedCompositingAvailable); #if ENABLE(3D_RENDERING) // In theory, we could have a software-based 3D rendering implementation that we use when // hardware-acceleration is not available. But we don't have any such software // implementation, so 3D rendering is only available when hardware-acceleration is. BOOL threeDRenderingAvailable = acceleratedCompositingAvailable; #else BOOL threeDRenderingAvailable = FALSE; #endif printf("SupportedFeatures:%s %s\n", acceleratedCompositingAvailable ? "AcceleratedCompositing" : "", threeDRenderingAvailable ? "3DRendering" : ""); return 0; }

Created attachment 103507 [details] Patch

Comment on attachment 103507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103507&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:232 > + supported_features_command = [self._path_to_driver(), '--print-supported-features'] > + output = self._executive.run_command(supported_features_command) I would just merge these lines.

Comment on attachment 103507 [details] Patch Clearing flags on attachment: 103507 Committed r92784: <http://trac.webkit.org/changeset/92784>

All reviewed patches have been landed. Closing bug.

This patch broke nrwt on Snow Leopard :( http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/32181 It's completely blocking my work at the moment.

When I run it locally, I get the following error: Traceback (most recent call last): File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 436, in <module> sys.exit(main()) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 431, in main return run(port, options, args) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 98, in run manager.parse_expectations() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 375, in parse_expectations port.test_expectations(), File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 327, in test_expectations expectations = self._skipped_list_as_expectations() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 343, in _skipped_list_as_expectations tests_to_skip = self.skipped_layout_tests() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 351, in skipped_layout_tests tests_to_skip.update(self._skipped_tests_for_unsupported_features()) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 274, in _skipped_tests_for_unsupported_features feature_list = self._runtime_feature_list() File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 232, in _runtime_feature_list output = self._executive.run_command(supported_features_command) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 441, in run_command (error_handler or self.default_error_handler)(script_error) File "/Volumes/Data/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 358, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'/Volumes/Data/webkit3/WebKitBuild/Debug/DumpRenderTree', u'--print-supported-features']" exit_code: 1

It appears that the regression has been fixed.

Yup. Thank you for the report.