Bug 61250

Summary: Use double quotes for filename arguments
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 55811    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-05-22 09:27:52 PDT
Use double quotes for filename arguments
Attachments
Patch (1.19 KB, patch)
2011-05-22 09:31 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-05-22 09:31:21 PDT
Created attachment 94346 [details] Patch
Adam Barth
Comment 2 2011-05-22 09:34:49 PDT
Comment on attachment 94346 [details] Patch Test?
Patrick R. Gansterer
Comment 3 2011-05-22 09:38:57 PDT
(In reply to comment #2) > (From update of attachment 94346 [details]) > Test? How? Are there any tests for the non VCSUtils perl scripts?
Adam Barth
Comment 4 2011-05-22 10:26:18 PDT
> How? Are there any tests for the non VCSUtils perl scripts? Dunno. Maybe we need to add more infrastructure to test-webkitperl ? Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff.
Patrick R. Gansterer
Comment 5 2011-05-22 10:28:32 PDT
(In reply to comment #4) > > How? Are there any tests for the non VCSUtils perl scripts? > > Dunno. Maybe we need to add more infrastructure to test-webkitperl ? Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff. I'm not against the tests, but I don't want to write the whole test infrastructure. :-/
WebKit Commit Bot
Comment 6 2011-05-22 11:08:14 PDT
Comment on attachment 94346 [details] Patch Clearing flags on attachment: 94346 Committed r87040: <http://trac.webkit.org/changeset/87040>
WebKit Commit Bot
Comment 7 2011-05-22 11:08:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.