Bug 59613

Summary:

Speech input button layout issues with padding and border.

Product:

WebKit

Reporter:

Satish Sampath <satish>

Component:

Forms

Assignee:

Satish Sampath <satish>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pfeldman, tkent, tonyg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

39485, 59742

Attachments:

Description	Flags
Patch	none
Updated an existing layout test to check for padding and rtl cases. Also fixed the code to handle RTL cases properly.	tonyg: review+

Satish Sampath

Reported 2011-04-27 09:01:02 PDT

The bounding box where the mouse cursor turns from an text insert cursor to a pointer is misaligned with the speech input mic icon. Here's one example that illustrates the problem: http://slides.html5rocks.com/#speech-input - the mic icon appears to partially overlap the right padding and for the right half of the mic icon the cursor turns into the text insert cursor. Ideally the button should appear inside and honour the padding of the input field.

Attachments
Patch (3.29 KB, patch) 2011-04-27 09:42 PDT, Satish Sampath	no flags	Details Formatted Diff Diff
Updated an existing layout test to check for padding and rtl cases. Also fixed the code to handle RTL cases properly. (8.35 KB, patch) 2011-04-28 08:27 PDT, Satish Sampath	tonyg: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Satish Sampath

Comment 1 2011-04-27 09:42:13 PDT

Created attachment 91300 [details] Patch

Tony Gentilcore

Comment 2 2011-04-28 03:36:16 PDT

Comment on attachment 91300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91300&action=review > Source/WebCore/ChangeLog:8 > + No new tests, existing tests cover this code. Is it really impossible to add a regression test for this bug? Seems like it would be easy to add a test for an input with padding, and click in particular locations to verify the bounds of the button target. > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:311 > + int x = width() - borderRight() - paddingRight() - button->width(); Does this work for RTL? Seems worth adding an rtl input to the click target test suggested above.

Satish Sampath

Comment 3 2011-04-28 08:27:04 PDT

Created attachment 91494 [details] Updated an existing layout test to check for padding and rtl cases. Also fixed the code to handle RTL cases properly.

Satish Sampath

Comment 4 2011-04-28 09:12:34 PDT

Committed r85190: <http://trac.webkit.org/changeset/85190>

Pavel Feldman

Comment 5 2011-04-28 09:19:05 PDT

Committed r85191: <http://trac.webkit.org/changeset/85191>

Note You need to log in before you can comment on or make changes to this bug.