Bug 59481

Summary:

[Qt][Symbian] API test failure qdeclarativewebview

Product:

WebKit

Reporter:

aravind.akella

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, benjamin, cmarcelo, hausmann, koshuin, laszlo.gombos, ossy, s.mathur, webkit.review.bot, yael

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Bug Depends on:

Bug Blocks:

38654

Attachments:

Description	Flags
Patch	hausmann: review-, hausmann: commit-queue-
Patch	none
Slightly cleaned up patch.	none

aravind.akella

Reported 2011-04-26 12:05:13 PDT

qt/tests/qdeclarativewebview/tst_qdeclarativewebview fails on symbian. Log file is attached.

Attachments
Patch (2.02 KB, patch) 2011-04-26 14:17 PDT, aravind.akella	hausmann: review- hausmann: commit-queue-	Details Formatted Diff Diff
Patch (2.04 KB, patch) 2011-04-27 06:44 PDT, aravind.akella	no flags	Details Formatted Diff Diff
Slightly cleaned up patch. (3.08 KB, patch) 2011-06-07 09:44 PDT, Siddharth Mathur	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

aravind.akella

Comment 1 2011-04-26 14:17:19 PDT

Created attachment 91156 [details] Patch qml files cannot be loaded on the symbian due to the differences in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll. It is giving a platsec error that Qtwebkit.dll has "DRM AllFiles" capabilities missing. Changing declarative.pro to match the capabilities set in QtWebKit.pro. Adding WriteDeviceData capability in tests.pri.

WebKit Review Bot

Comment 2 2011-04-26 14:20:19 PDT

Attachment 91156 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Hausmann

Comment 3 2011-04-26 15:17:41 PDT

Comment on attachment 91156 [details] Patch I _think_ this is probably the correct solution, but let's see what Laszlo or Janne say. I'm r-'ing this one due to the style issues reported (no tabs in the ChangeLog).

aravind.akella

Comment 4 2011-04-27 06:44:11 PDT

Created attachment 91277 [details] Patch Resubmitting the patch. Changed the tabs to spaces in ChangeLog.

Janne Koskinen

Comment 5 2011-04-28 07:01:16 PDT

Patch looks ok for developer signed DLLs. Though, not entirely sure if this kind of patching is needed. Qt DLLs use all - tcb for production as they should and in case of self/developer signing patch_capabilities.pl is used. What device data we are writing? Could it be that the directories are wrong and we end up writing in dir that we shouldn't be ?

Eric Seidel (no email)

Comment 6 2011-05-01 10:51:51 PDT

Comment on attachment 91277 [details] Patch rs=me.

Eric Seidel (no email)

Comment 7 2011-05-01 10:52:34 PDT

Comment on attachment 91277 [details] Patch Leaving the cq+ off, to give real nokia contributors more time to comment.

Benjamin Poulain

Comment 8 2011-05-02 10:56:34 PDT

Any symbian dev has comment regarding what Janne said?

Siddharth Mathur

Comment 9 2011-06-07 09:44:21 PDT

Created attachment 96252 [details] Slightly cleaned up patch. Changes from Aravind's last patch: - improved Changelog comment - similar to QtWebKit.pro, uses the CONFIG(production) flag for the QML plugin as well as platform plugin - removes use of TARGET.VID from Yi Shen's platform plugin .pro file. (we don't use it in any other WebKit DLL)

Laszlo Gombos

Comment 10 2011-06-07 11:01:27 PDT

Comment on attachment 91277 [details] Patch I plan to advance https://bug-59481-attachments.webkit.org/attachment.cgi?id=96252 instead, so clearing r+.

Laszlo Gombos

Comment 11 2011-06-07 11:12:07 PDT

Comment on attachment 96252 [details] Slightly cleaned up patch. Looks great, thanks !

WebKit Review Bot

Comment 12 2011-06-07 12:17:52 PDT

Comment on attachment 96252 [details] Slightly cleaned up patch. Clearing flags on attachment: 96252 Committed r88253: <http://trac.webkit.org/changeset/88253>

WebKit Review Bot

Comment 13 2011-06-07 12:17:57 PDT

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 14 2011-06-07 12:55:16 PDT

Revision r88253 cherry-picked into qtwebkit-2.2 with commit 7b8defb <http://gitorious.org/webkit/qtwebkit/commit/7b8defb>

Note You need to log in before you can comment on or make changes to this bug.