Bug 58447

Summary: Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review-
Patch none

Vsevolod Vlasov
Reported 2011-04-13 09:10:19 PDT
Add encodedDataLength field to ResourceResponse and use it for synchronous requests transfer size
Attachments
Patch (3.96 KB, patch)
2011-04-13 09:18 PDT, Vsevolod Vlasov 		pfeldman: review-
DetailsFormatted DiffDiff
Patch (4.56 KB, patch)
2011-04-14 05:12 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-04-13 09:18:53 PDT
Created attachment 89386 [details] Patch
Pavel Feldman
Comment 2 2011-04-14 03:55:08 PDT
Comment on attachment 89386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review > Source/WebCore/loader/FrameLoader.cpp:2829 > + notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error); what are the implications of this change? > Source/WebCore/platform/network/ResourceResponseBase.h:68 > + long long encodedDataLength() const; This should be a part of ResourceLoadInfo.
Vsevolod Vlasov
Comment 3 2011-04-14 05:12:43 PDT
Created attachment 89558 [details] Patch (In reply to comment #2) > (From update of attachment 89386 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review > > > Source/WebCore/loader/FrameLoader.cpp:2829 > > + notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error); > > what are the implications of this change? This parameter was introduced by my previous change and the value passed here was not correct. Now we are passing a correct value that will be forwarded to didReceiveData. > > Source/WebCore/platform/network/ResourceResponseBase.h:68 > > + long long encodedDataLength() const; > > This should be a part of ResourceLoadInfo. Done.
WebKit Commit Bot
Comment 4 2011-04-14 21:27:10 PDT
The commit-queue encountered the following flaky tests while processing attachment 89558 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-04-14 21:30:11 PDT
Comment on attachment 89558 [details] Patch Clearing flags on attachment: 89558 Committed r83942: <http://trac.webkit.org/changeset/83942>
WebKit Commit Bot
Comment 6 2011-04-14 21:30:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.