Bug 57865

Summary: [Qt] Improve tests for QWebFrame::url() and related methods
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: WebKit QtAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on:    
Bug Blocks: 32723    
Attachments:
Description Flags
Patch none

Caio Marcelo de Oliveira Filho
Reported 2011-04-05 11:18:52 PDT
[Qt] Improve tests for QWebFrame::url() and related methods
Attachments
Patch (9.92 KB, patch)
2011-04-05 11:21 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-04-05 11:21:24 PDT
Created attachment 88283 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2011-04-05 11:26:57 PDT
Kenneth and Benjamin, I've decided to split the test case improvements in a separated bug. The tests were outside of the scope of the original patch for fragment handling. The idea is to document the existing url()/requestedUrl()/setUrl() and friends behavior better so we have more confidence when changing the innards of QWebFrame.
WebKit Commit Bot
Comment 3 2011-04-06 02:37:55 PDT
Comment on attachment 88283 [details] Patch Clearing flags on attachment: 88283 Committed r83036: <http://trac.webkit.org/changeset/83036>
WebKit Commit Bot
Comment 4 2011-04-06 02:38:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.