Bug 57666

Summary: [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
Product: WebKit Reporter: Keith Kyzivat <kamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, laszlo.gombos, ossy
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Fixed patch with proper rename none

Keith Kyzivat
Reported 2011-04-01 14:59:18 PDT
Svn rev 82671 caused a regression in MiniBrowser compilation -- .qrc is not found, as it should have moved to the qt/ directory.
Attachments
Patch (641 bytes, patch)
2011-04-01 15:14 PDT, Keith Kyzivat 		no flags
DetailsFormatted DiffDiff
Fixed patch with proper rename (1.13 KB, patch)
2011-04-01 15:17 PDT, Keith Kyzivat 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Kyzivat
Comment 1 2011-04-01 15:14:11 PDT
Created attachment 87924 [details] Patch
Keith Kyzivat
Comment 2 2011-04-01 15:15:30 PDT
I see what the problem was... webkit-patch post <bug> is not properly working with git renames - as can be evidenced here.. will post patch with git diff --staged now..
Keith Kyzivat
Comment 3 2011-04-01 15:17:23 PDT
Created attachment 87925 [details] Fixed patch with proper rename Fixed patch with proper rename
Csaba Osztrogonác
Comment 4 2011-04-01 15:40:31 PDT
Comment on attachment 87925 [details] Fixed patch with proper rename LGTM, r=me
WebKit Commit Bot
Comment 5 2011-04-01 18:38:21 PDT
The commit-queue encountered the following flaky tests while processing attachment 87925 [details]: fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-01 18:41:13 PDT
Comment on attachment 87925 [details] Fixed patch with proper rename Clearing flags on attachment: 87925 Committed r82755: <http://trac.webkit.org/changeset/82755>
WebKit Commit Bot
Comment 7 2011-04-01 18:41:18 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2011-04-01 19:34:20 PDT
The commit-queue encountered the following flaky tests while processing attachment 87925 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.