Bug 54390

Summary: Web Inspector: move timeline and highlighter tests to the new harness.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 54442    
Bug Blocks:    
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-02-14 06:35:55 PST
Patch to follow.
Attachments
Patch (54.51 KB, patch)
2011-02-14 06:44 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-02-14 06:44:56 PST
Created attachment 82312 [details] Patch
Yury Semikhatsky
Comment 2 2011-02-14 07:04:21 PST
Comment on attachment 82312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82312&action=review > LayoutTests/inspector/timeline-script-tag-2.js:-1 > -console.markTimeline("SCRIPT TAG"); I don't see the call to markTimeline anymore, is it intentional?
Yury Semikhatsky
Comment 3 2011-02-14 07:32:43 PST
Comment on attachment 82312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82312&action=review > LayoutTests/inspector/resources/timeline-iframe-data.html:8 > + console.log("iframe loaded"); Please file a bug about sending messages from the inspected page to the front-end.
Pavel Feldman
Comment 4 2011-02-14 07:37:05 PST
Comment on attachment 82312 [details] Patch It is intentional.
Pavel Feldman
Comment 5 2011-02-14 07:44:11 PST
Committed r78477: <http://trac.webkit.org/changeset/78477>
WebKit Review Bot
Comment 6 2011-02-14 08:39:22 PST
http://trac.webkit.org/changeset/78477 might have broken Qt Linux Release The following tests are not passing: inspector/timeline-network-resource.html inspector/timeline-script-tag-1.html
Note You need to log in before you can comment on or make changes to this bug.