Bug 51279

Summary:

Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces

Product:

WebKit

Reporter:

Matthew Delaney <mdelaney7>

Component:

Canvas

Assignee:

Matthew Delaney <mdelaney7>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mdelaney7, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	simon.fraser: review+, commit-queue: commit-queue-

Matthew Delaney

Reported 2010-12-17 15:48:46 PST

Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces

Attachments
Patch (6.72 KB, patch) 2010-12-17 15:54 PST, Matthew Delaney	no flags	Details Formatted Diff Diff
Patch (1.50 KB, patch) 2010-12-22 11:11 PST, Matthew Delaney	no flags	Details Formatted Diff Diff
Patch (9.24 KB, patch) 2010-12-22 16:39 PST, Matthew Delaney	no flags	Details Formatted Diff Diff
Patch (10.41 KB, patch) 2010-12-22 18:07 PST, Matthew Delaney	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Matthew Delaney

Comment 1 2010-12-17 15:54:41 PST

Created attachment 76922 [details] Patch

Simon Fraser (smfr)

Comment 2 2010-12-17 15:59:36 PST

Comment on attachment 76922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76922&action=review > WebCore/ChangeLog:9 > + No new tests. Current canvas layout tests sufficient. If you're fixing a bug here, that's not true. > WebCore/platform/graphics/ImageBuffer.h:43 > -#define USE_IOSURFACE 1 > +#define WTF_USE_IOSURFACE 1 USE(IOSURFACE) is too vague when read out of context. It should be something like USE(IOSURFACE_CANVAS_BACKING_STORE) or something. It's also rare, not not unknown, to #define a WTF macro outside of config.h

Matthew Delaney

Comment 3 2010-12-22 11:11:27 PST

Created attachment 77240 [details] Patch

Matthew Delaney

Comment 4 2010-12-22 11:21:38 PST

(In reply to comment #2) > (From update of attachment 76922 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76922&action=review > > > WebCore/ChangeLog:9 > > + No new tests. Current canvas layout tests sufficient. > > If you're fixing a bug here, that's not true. Sorry, I should have pointed it out amongst all the similarly looking find-and-replace lines of the USE(IOSurface) renaming. This new patch has just the fix and I'll put the renaming in another patch.

Simon Fraser (smfr)

Comment 5 2010-12-22 14:16:54 PST

Comment on attachment 77240 [details] Patch There is certainly a behavior change here, so it should be testable.

Matthew Delaney

Comment 6 2010-12-22 16:39:34 PST

Created attachment 77275 [details] Patch

Simon Fraser (smfr)

Comment 7 2010-12-22 16:50:02 PST

Comment on attachment 77275 [details] Patch We don't tend to use interCaps for layout test files. Please rename it to accelerated-canvas-compositing.html Also add a few words to the text file to say what is being tested.

Matthew Delaney

Comment 8 2010-12-22 18:07:11 PST

Created attachment 77288 [details] Patch

WebKit Commit Bot

Comment 9 2010-12-22 21:00:11 PST

The commit-queue encountered the following flaky tests while processing attachment 77288 [details]: fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 10 2010-12-22 21:01:22 PST

Comment on attachment 77288 [details] Patch Rejecting attachment 77288 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 77288]" exit_code: 2 Last 500 characters of output: file svnlook: Path 'trunk/LayoutTests/platform/mac-snowleopard/platform/mac/compositing/canvas' is not a file The following files contain tab characters: trunk/LayoutTests/platform/mac/compositing/canvas/accelerated-canvas-compositing.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 573 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/7307122

Matthew Delaney

Comment 11 2010-12-23 11:58:35 PST

Committed r74570: <http://trac.webkit.org/changeset/74570>

Note You need to log in before you can comment on or make changes to this bug.