Bug 46621

Summary: [Qt] Make generate-forwarding-headers.pl aware of moved headers
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, eric, ossy
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Andras Becsi
Reported 2010-09-27 07:24:48 PDT
Changeset http://trac.webkit.org/changeset/68357 revealed an incremental build issue: if headers are moved the script does not regenerate the corresponding forwarding headers. Make generate-forwarding-headers.pl more robust by checking the content of existing forwarding headers and regenerating them if they do not contain what's expected.
Attachments
proposed patch (1.94 KB, patch)
2010-09-27 07:28 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-09-27 07:28:43 PDT
Created attachment 68907 [details] proposed patch
Csaba Osztrogonác
Comment 2 2010-09-27 11:15:02 PDT
Comment on attachment 68907 [details] proposed patch It will make WebKit2 build system more robust without any needless forwarding header regeneration and performace regression. Great fix, r=me.
WebKit Commit Bot
Comment 3 2010-09-27 11:15:56 PDT
Comment on attachment 68907 [details] proposed patch Rejecting patch 68907 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 68907]" exit_code: 2 Cleaning working directory Updating working directory Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Full output: http://queues.webkit.org/results/4074123
Csaba Osztrogonác
Comment 4 2010-09-27 11:27:02 PDT
Comment on attachment 68907 [details] proposed patch Clearing flags on attachment: 68907 Committed r68409: <http://trac.webkit.org/changeset/68409>
Csaba Osztrogonác
Comment 5 2010-09-27 11:27:11 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 6 2010-09-27 11:32:29 PDT
False rejection. Bug in the queue. One of the cluster nodes seems stuck.
Andras Becsi
Comment 7 2010-09-27 11:36:25 PDT
(In reply to comment #4) > (From update of attachment 68907 [details]) > Clearing flags on attachment: 68907 > > Committed r68409: <http://trac.webkit.org/changeset/68409> Thanks, Ossy for landing it.
Note You need to log in before you can comment on or make changes to this bug.