Bug 40184

Summary: Remove side effects of form submission and prepare FormDataBuilder for splitting up.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 40137    
Bug Blocks: 40893    
Attachments:
Description Flags
Patch
none
Patch darin: review+

Dimitri Glazkov (Google)
Reported 2010-06-04 13:15:55 PDT
Remove side-effects of form submission and prepare FormDataBuilder for splitting up.
Attachments
Patch (13.08 KB, patch)
2010-06-04 13:28 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (13.14 KB, patch)
2010-06-21 16:32 PDT, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-06-04 13:28:01 PDT
Created attachment 57909 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-06-21 16:32:56 PDT
Created attachment 59309 [details] Patch
Darin Adler
Comment 3 2010-06-21 22:16:31 PDT
Comment on attachment 59309 [details] Patch > + m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded"); Why is it important to call the parse function instead of the set function here? r=me
Dimitri Glazkov (Google)
Comment 4 2010-06-22 08:54:45 PDT
(In reply to comment #3) > (From update of attachment 59309 [details]) > > + m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded"); > > Why is it important to call the parse function instead of the set function here? That's actually a good question and points to a problem that I'll figure out how to solve. parseEncodingType sets isMultiPart to false, which is still kind of side-effecty. See assert right next to this statement. > > r=me
Dimitri Glazkov (Google)
Comment 5 2010-06-22 08:56:39 PDT
Committed r61618: <http://trac.webkit.org/changeset/61618>
Note You need to log in before you can comment on or make changes to this bug.