Bug 37634

Summary: Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: AccessibilityAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 18662    
Bug Blocks: 35874    
Attachments:
Description Flags
(committed: r57662) patch v1 none

Antonio Gomes
Reported 2010-04-14 21:01:20 PDT
in the quoted code below, the assignment line is not needed any more after bug 36168 (patch 51940) landed. @@ -364,8 +364,6 @@ static void updateFocusCandidateIfCloser(Node* focusedNode, const FocusCandidate if (closest.alignment < candidate.alignment && closest.parentAlignment < candidate.alignment) closest.distance = maxDistance(); - - closest.alignment = candidate.alignment; } reason, all assignment takes place lines below in the same method, and not class member by class member. in other words, now instead of: closest.alignment = candidate.alignment, we have closest = candidate later on in the same method.
Attachments
(committed: r57662) patch v1 (2.13 KB, patch)
2010-04-14 21:06 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-04-14 21:06:16 PDT
Created attachment 53404 [details] (committed: r57662) patch v1
Antonio Gomes
Comment 2 2010-04-15 12:42:27 PDT
Comment on attachment 53404 [details] (committed: r57662) patch v1 Clearing flags on attachment: 53434 Committed r57662: <http://trac.webkit.org/changeset/57662>
Antonio Gomes
Comment 3 2010-04-15 12:43:20 PDT
Thank you Simon Fraser!
Note You need to log in before you can comment on or make changes to this bug.